Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: gyp/opts.gyp

Issue 180873012: Updates to gyp files for building Android.mk (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Also remove g Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/common_conditions.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/opts.gyp
diff --git a/gyp/opts.gyp b/gyp/opts.gyp
index 0d3b2e3d6aae9153f0796976790c536ea16f4f16..2fd0e95809e5bb07dc3467ecce203fe66e657d63 100644
--- a/gyp/opts.gyp
+++ b/gyp/opts.gyp
@@ -114,6 +114,14 @@
'../src/opts/SkXfermode_opts_none.cpp',
],
}],
+ [ 'skia_android_framework', {
+ 'cflags!': [
+ '-msse2',
djsollen 2014/02/28 13:54:21 is there any way to tell gyp to unset all the cfla
scroggo 2014/02/28 14:17:21 I don't know how to tell gyp that, but I could do
+ '-mfpu=neon',
+ '-fomit-frame-pointer',
+ '-mno-apcs-frame',
+ ]
+ }],
],
},
# For the same lame reasons as what is done for skia_opts, we have to
@@ -133,7 +141,8 @@
'../src/core',
],
'conditions': [
- [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl", "chromeos", "android"]', {
+ [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl", "chromeos", "android"] \
+ and not skia_android_framework', {
'cflags': [
'-mssse3',
],
@@ -169,9 +178,13 @@
'-mfpu=vfpv3',
'-mfpu=vfpv3-d16',
],
- 'cflags': [
- '-mfpu=neon',
- '-fomit-frame-pointer',
+ 'conditions': [
+ [ 'not skia_android_framework', {
+ 'cflags': [
+ '-mfpu=neon',
+ '-fomit-frame-pointer',
+ ],
+ }],
],
'ldflags': [
'-march=armv7-a',
« no previous file with comments | « gyp/common_conditions.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698