tools/telemetry/telemetry/page/page_runner_unittest.py - Issue 180873008: Add support for python pageset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 180873008: Add support for python pageset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove attributes from page constructor Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py

index f85779d98dbaa78a8dfea35d0ea2eea70d179b76..1b0d560f0541718f9b446c94ecd51cbfc25d21a7 100644

--- a/tools/telemetry/telemetry/page/page_runner_unittest.py

+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py

@@ -399,10 +399,10 @@ class PageRunnerTests(unittest.TestCase):

super(Measurement, self).__init__()

self.browser_restarted = False

- def CustomizeBrowserOptionsForPageSet(self, ps, options):

+ def CustomizeBrowserOptionsForSinglePage(self, ps, options):

self.browser_restarted = True

- super(Measurement, self).CustomizeBrowserOptionsForPageSet(ps,

- options)

+ super(Measurement, self).CustomizeBrowserOptionsForSinglePage(ps,

+ options)

def MeasurePage(self, page, tab, results):

pass