tools/telemetry/telemetry/page/page_runner.py - Issue 180873008: Add support for python pageset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 180873008: Add support for python pageset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove attributes from page constructor Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index b264c2cab4c25424cfb49f0c0311ce53ce988a59..5cc2d6768dadfbf259b08ed4d97929f0d12497e6 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -326,8 +326,6 @@ def Run(test, page_set, expectations, finder_options):

if page_set.user_agent_type:

browser_options.browser_user_agent_type = page_set.user_agent_type

- test.CustomizeBrowserOptionsForPageSet(page_set,

- possible_browser.finder_options)

if finder_options.profiler:

profiler_class = profiler_finder.FindProfiler(finder_options.profiler)

profiler_class.CustomizeBrowserOptions(possible_browser.browser_type,