third_party/pkg/angular/test/io/expression_extractor_spec.dart - Issue 180873006: Update the Angular/DI tests to latest from github.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/pkg/angular/test/io/expression_extractor_spec.dart

Issue 180873006: Update the Angular/DI tests to latest from github. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Review feedback Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/pkg/angular/test/filter/uppercase_spec.dart ('k') | third_party/pkg/angular/test/io/source_metadata_extractor_spec.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/pkg/angular/test/io/expression_extractor_spec.dart

diff --git a/third_party/pkg/angular/test/io/expression_extractor_spec.dart b/third_party/pkg/angular/test/io/expression_extractor_spec.dart

index 5d3d7fc6baa2d49444f5a0af96f7031154886467..5ecc402d6f33d1c92f7a4ec439823db26236fa36 100644

--- a/third_party/pkg/angular/test/io/expression_extractor_spec.dart

+++ b/third_party/pkg/angular/test/io/expression_extractor_spec.dart

@@ -20,12 +20,12 @@ main() => describe('expression_extractor', () {

IoService ioService = new IoServiceImpl();

var sourceCrawler = new SourceCrawlerImpl(['packages/']);

- var sourceMetadataExtractor = new SourceMetadataExtractor(sourceCrawler);

+ var sourceMetadataExtractor = new SourceMetadataExtractor();

List<DirectiveInfo> directives =

sourceMetadataExtractor

- .gatherDirectiveInfo('test/io/test_files/main.dart');

- var htmlExtractor = new HtmlExpressionExtractor(directives, ioService);

- htmlExtractor.crawl('test/io/test_files/');

+ .gatherDirectiveInfo('test/io/test_files/main.dart', sourceCrawler);

+ var htmlExtractor = new HtmlExpressionExtractor(directives);

+ htmlExtractor.crawl('test/io/test_files/', ioService);

var expressions = htmlExtractor.expressions;

expect(expressions, unorderedEquals([