third_party/pkg/angular/test/filter/uppercase_spec.dart - Issue 180873006: Update the Angular/DI tests to latest from github.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/pkg/angular/test/filter/uppercase_spec.dart

Issue 180873006: Update the Angular/DI tests to latest from github. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Review feedback Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/pkg/angular/test/filter/order_by_spec.dart ('k') | third_party/pkg/angular/test/io/expression_extractor_spec.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/pkg/angular/test/filter/uppercase_spec.dart

diff --git a/third_party/pkg/angular/test/filter/uppercase_spec.dart b/third_party/pkg/angular/test/filter/uppercase_spec.dart

index be81f6e5c89b11dc2f59fb46d97b697ef6c46e21..803b35605140ca77775fdb82a4e7790549740821 100644

--- a/third_party/pkg/angular/test/filter/uppercase_spec.dart

+++ b/third_party/pkg/angular/test/filter/uppercase_spec.dart

@@ -3,8 +3,8 @@ library uppercase_spec;

import '../_specs.dart';

main() => describe('uppercase', () {

- it('should convert string to uppercase', inject((Scope scope) {

- expect(scope.$eval('null | uppercase')).toEqual(null);

- expect(scope.$eval('"foo" | uppercase')).toEqual('FOO');

+ it('should convert string to uppercase', inject((Parser parse, FilterMap filters) {

+ expect(parse('null | uppercase').eval(null, filters)).toEqual(null);

+ expect(parse('"foo" | uppercase').eval(null, filters)).toEqual('FOO');

}));

});