Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1808533002: DevTools: wrap console evaluation with user gesture indicator for convenience. (Closed)

Created:
4 years, 9 months ago by pfeldman
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: wrap console evaluation with user gesture indicator for convenience. BUG=593241 Committed: https://crrev.com/5db661ff8e8dcd081145ea28b183b48b20a087c1 Cr-Commit-Position: refs/heads/master@{#381511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 4 chunks +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 6 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pfeldman
4 years, 9 months ago (2016-03-15 22:40:32 UTC) #2
dgozman
lgtm
4 years, 9 months ago (2016-03-15 23:18:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808533002/1
4 years, 9 months ago (2016-03-16 01:20:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157417)
4 years, 9 months ago (2016-03-16 01:31:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808533002/1
4 years, 9 months ago (2016-03-16 19:26:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 19:33:30 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 19:34:48 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5db661ff8e8dcd081145ea28b183b48b20a087c1
Cr-Commit-Position: refs/heads/master@{#381511}

Powered by Google App Engine
This is Rietveld 408576698