third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp - Issue 1808533002: DevTools: wrap console evaluation with user gesture indicator for convenience.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 1808533002: DevTools: wrap console evaluation with user gesture indicator for convenience. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

index 3a666bbf42292c9526c5b01d0f99c1b254658e91..5139a1d831ba25b4391a1db7707cca4df6c5f7f5 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

@@ -80,6 +80,7 @@ void V8RuntimeAgentImpl::evaluate(

const Maybe<int>& executionContextId,

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,

+ const Maybe<bool>& userGesture,

OwnPtr<RemoteObject>* result,

Maybe<bool>* wasThrown,

Maybe<ExceptionDetails>* exceptionDetails)

@@ -104,6 +105,7 @@ void V8RuntimeAgentImpl::callFunctionOn(ErrorString* errorString,

const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,

+ const Maybe<bool>& userGesture,

OwnPtr<RemoteObject>* result,

Maybe<bool>* wasThrown)

{

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h ('k') | no next file » | no next file with comments »