Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 1808513006: Introduce PlatformNotification structures and converters (Closed)

Created:
4 years, 9 months ago by Peter Beverloo
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, dglazkov+blink, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-mojo-hacks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce PlatformNotification structures and converters Since modules cannot depend on either Mojo or base yet, introduce a new Notification representation in platform together with a converter between itself and the notification.mojom file. It will be trivial to switch the notification module over to use this structure rather than the Blink API one, but that depends on Chromium moving over to Mojo for notifications as well. Also generate Mojo bindings twice for mojom files defined in Blink: once backed by WTF, once backed by STL. The former are meant to be used by users within Blink, whereas the latter are meant for outside Blink usages. I chose to use "wtf" as the variant rather than "blink" because of the namespacing that's already in place: "blink::mojom::wtf::*" vs. "blink::mojom::blink::*". BUG=595685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/PlatformNotification.h View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/PlatformNotification.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/PlatformNotificationConverters.h View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/PlatformNotificationConverters.cpp View 1 chunk +117 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/PlatformNotificationConvertersTest.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +18 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink.gyp View 2 chunks +26 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
Peter Beverloo
+esprehn for the union of Blink, WTF, STL and Mojo. +mvanouwerkerk for notifications This builds ...
4 years, 9 months ago (2016-03-17 20:13:01 UTC) #2
esprehn
modules/ can depend on Mojo today, there's a WTF friendly bindings generator. base::Time will probably ...
4 years, 9 months ago (2016-03-18 05:01:30 UTC) #3
Peter Beverloo
4 years, 9 months ago (2016-03-18 18:04:10 UTC) #4
On 2016/03/18 05:01:30, esprehn wrote:
> modules/ can depend on Mojo today, there's a WTF friendly bindings generator.
> base::Time will probably not be coming to blink outside platform, you'll want
to
> keep helpers in platform that deal with that for you. The web represents time
as
> a double.

Good, then we don't need these classes :).

Split off the Mojo generation to https://codereview.chromium.org/1819473002.

Powered by Google App Engine
This is Rietveld 408576698