Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5274)

Unified Diff: chrome/browser/platform_util_chromeos.cc

Issue 18083022: Implement platform_util::OpenExternal on ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/apps/chrome_shell_window_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/platform_util_chromeos.cc
diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc
index 1d68cab96cae79c89523e66d4b20c3e5d829c845..5f3e7e6043963a06768ba11faeaa3b7a33e01f2b 100644
--- a/chrome/browser/platform_util_chromeos.cc
+++ b/chrome/browser/platform_util_chromeos.cc
@@ -29,6 +29,7 @@ void OpenURL(const std::string& url) {
chrome::NavigateParams params(
browser, GURL(url), content::PAGE_TRANSITION_LINK);
params.disposition = NEW_FOREGROUND_TAB;
+ params.window_action = chrome::NavigateParams::SHOW_WINDOW;
Ken Rockot(use gerrit already) 2013/07/01 20:16:18 Is there any reason why an explicit SHOW_WINDOW wo
sky 2013/07/02 00:35:42 Not that I can think of. In fact I suspect the old
chrome::Navigate(&params);
}
@@ -61,6 +62,9 @@ void OpenExternal(const GURL& url) {
string_url.append(url.spec());
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
base::Bind(OpenURL, string_url));
+ } else if (url.is_valid()) {
sky 2013/07/02 00:35:42 What code is this being expected on? It seems like
sky 2013/07/02 00:35:55 That should be thread. Sorry.
Ken Rockot(use gerrit already) 2013/07/02 01:37:51 ExternalProtocolHandler does call OpenExternal fro
+ BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+ base::Bind(OpenURL, url.spec()));
}
}
« no previous file with comments | « no previous file | chrome/browser/ui/apps/chrome_shell_window_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698