Implement platform_util::OpenExternal on ChromeOS

chrome/browser/platform_util_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include "base/bind.h"
 #include "chrome/browser/chromeos/extensions/file_manager/file_manager_util.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 11 matching lines @@
     "https://mail.google.com/mail/?extsrc=mailto&url=";
 
 void OpenURL(const std::string& url) {
   // TODO(beng): improve this to locate context from call stack.
   Browser* browser = chrome::FindOrCreateTabbedBrowser(
       ProfileManager::GetDefaultProfileOrOffTheRecord(),
       chrome::HOST_DESKTOP_TYPE_ASH);
   chrome::NavigateParams params(
       browser, GURL(url), content::PAGE_TRANSITION_LINK);
   params.disposition = NEW_FOREGROUND_TAB;
+  params.window_action = chrome::NavigateParams::SHOW_WINDOW;

[Ken Rockot(use gerrit already), 2013/07/01 20:16:18]

Is there any reason why an explicit SHOW_WINDOW would be a problem here?

[sky, 2013/07/02 00:35:42]

Not that I can think of. In fact I suspect the old code was problematic if
FindOrCreateTabbedBrowser created a new browser.

   chrome::Navigate(&params);
 }
 
 }  // namespace
 
 namespace platform_util {
 
 void ShowItemInFolder(const base::FilePath& full_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   file_manager_util::ShowFileInFolder(full_path);
@@ skipping 12 matching lines @@
   //     In this case we would need to have this in place.
   // b.) There are several code paths which are not clear if they would call
   //     this function directly and which would therefore break (e.g.
   //     "Browser::EmailPageLocation" (to name only one).
   // As such we should keep this code here.
   if (url.SchemeIs("mailto")) {
     std::string string_url = kGmailComposeUrl;
     string_url.append(url.spec());
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
                             base::Bind(OpenURL, string_url));
+  } else if (url.is_valid()) {

[sky, 2013/07/02 00:35:42]

What code is this being expected on? It seems like there is no need for a
posttask, but maybe I'm missing something.

[sky, 2013/07/02 00:35:55]

That should be thread. Sorry.

[Ken Rockot(use gerrit already), 2013/07/02 01:37:51]

ExternalProtocolHandler does call OpenExternal from the IO thread, but we could
always add a check here to call OpenURL directly when possible.

+    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+                            base::Bind(OpenURL, url.spec()));
   }
 }
 
 }  // namespace platform_util