Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1808243002: [arm][arm64] Disable COHERENT_CACHE support (Closed)

Created:
4 years, 9 months ago by Jakob Kummerow
Modified:
4 years, 9 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm][arm64] Disable COHERENT_CACHE support This is an experiment to see if it affects crash rates on Nexus 9 devices. A small performance impact (3-4% on Octane) is expected. BUG=chromium:524337 LOG=n R=hablich@chromium.org Committed: https://crrev.com/45616bfb27266359daeb0aded1a24f89a58a1b80 Cr-Commit-Position: refs/heads/master@{#34896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
4 years, 9 months ago (2016-03-17 15:49:23 UTC) #1
Michael Hablich
On 2016/03/17 15:49:23, Jakob wrote: lgtm
4 years, 9 months ago (2016-03-18 14:40:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808243002/1
4 years, 9 months ago (2016-03-18 14:44:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 15:02:39 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 15:03:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45616bfb27266359daeb0aded1a24f89a58a1b80
Cr-Commit-Position: refs/heads/master@{#34896}

Powered by Google App Engine
This is Rietveld 408576698