Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: src/arm/assembler-arm.cc

Issue 1808243002: [arm][arm64] Disable COHERENT_CACHE support (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/assembler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 (cpu.part() == base::CPU::ARM_CORTEX_A5 || 138 (cpu.part() == base::CPU::ARM_CORTEX_A5 ||
139 cpu.part() == base::CPU::ARM_CORTEX_A9)) { 139 cpu.part() == base::CPU::ARM_CORTEX_A9)) {
140 dcache_line_size_ = 32; 140 dcache_line_size_ = 32;
141 } 141 }
142 142
143 if (FLAG_enable_32dregs && cpu.has_vfp3_d32()) supported_ |= 1u << VFP32DREGS; 143 if (FLAG_enable_32dregs && cpu.has_vfp3_d32()) supported_ |= 1u << VFP32DREGS;
144 144
145 if (cpu.implementer() == base::CPU::NVIDIA && 145 if (cpu.implementer() == base::CPU::NVIDIA &&
146 cpu.variant() == base::CPU::NVIDIA_DENVER && 146 cpu.variant() == base::CPU::NVIDIA_DENVER &&
147 cpu.part() <= base::CPU::NVIDIA_DENVER_V10) { 147 cpu.part() <= base::CPU::NVIDIA_DENVER_V10) {
148 supported_ |= 1u << COHERENT_CACHE; 148 // TODO(jkummerow): This is turned off as an experiment to see if it
149 // affects crash rates. Keep an eye on crash reports and either remove
150 // coherent cache support permanently, or re-enable it!
151 // supported_ |= 1u << COHERENT_CACHE;
149 } 152 }
150 #endif 153 #endif
151 154
152 DCHECK(!IsSupported(VFP3) || IsSupported(ARMv7)); 155 DCHECK(!IsSupported(VFP3) || IsSupported(ARMv7));
153 } 156 }
154 157
155 158
156 void CpuFeatures::PrintTarget() { 159 void CpuFeatures::PrintTarget() {
157 const char* arm_arch = NULL; 160 const char* arm_arch = NULL;
158 const char* arm_target_type = ""; 161 const char* arm_target_type = "";
(...skipping 4003 matching lines...) Expand 10 before | Expand all | Expand 10 after
4162 DCHECK(is_uint12(offset)); 4165 DCHECK(is_uint12(offset));
4163 instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset)); 4166 instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset));
4164 } 4167 }
4165 } 4168 }
4166 4169
4167 4170
4168 } // namespace internal 4171 } // namespace internal
4169 } // namespace v8 4172 } // namespace v8
4170 4173
4171 #endif // V8_TARGET_ARCH_ARM 4174 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/assembler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698