Refactor oobe/login screens so lock screen can be loaded faster.

Refactor oobe/login screens so lock screen can be loaded faster.

Split lock screen from login assets, so lock screen only loads the minimal number of files needed.

Split login_common.js into two files, login_shared.js and login_non_lock_shared.js.

Split login_resources.html into two files, login_shared.html and login_non_lock_shared.html.

Lazy load polymer for user_pod_template.

BUG=452599
Committed: https://crrev.com/3ce610430e914400d917c949d2811293c28505b9
Cr-Commit-Position: refs/heads/master@{#386789}

[jdufault, 2016-03-17 21:27:05]

Description was changed from

==========
Refactor oobe/login screens so lock screen can be loaded faster.

BUG=452599
==========

to

==========
Refactor oobe/login screens so lock screen can be loaded faster.

Split lock screen from login assets, so lock screen only loads the minimal
number of files needed.

Split login_common.js into two files, login_shared.js and
login_login_oobe_shared.js.

Split login_resources.html into two files, login_shared.html and
login_login_oobe_shared.html.

Lazy load polymer for user_pod_template.



BUG=452599
==========

[jdufault, 2016-03-17 21:30:57]

Patchset #1 (id:1) has been deleted

[jdufault, 2016-03-17 21:32:07]

jdufault@chromium.org changed reviewers:
+ dzhioev@chromium.org

[jdufault, 2016-03-17 21:34:20]

Pavel PTAL. I'm still not sure about the polymer lazy loading, I need to do more
testing there. Also I'm not a fan of "login_login_oobe_shared" as a name; any
ideas for a better one?

[dzhioev (left Google), 2016-03-25 22:17:19]

On 2016/03/17 21:34:20, jdufault wrote:
> Pavel PTAL. I'm still not sure about the polymer lazy loading, I need to do
more
> testing there. Also I'm not a fan of "login_login_oobe_shared" as a name; any
> ideas for a better one?

I'm not sure about lazy loading of Polymer as well. I don't think that lazy
loading
of a single file will save us much time. On the other hand it can possible lead
to UI glitches.

About "login_login_oobe_shared": I thing just "non_lock_shared" would be OK.

[dzhioev (left Google), 2016-03-25 22:17:36]

https://codereview.chromium.org/1808223003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/login_login_oobe_shared.js (right):

https://codereview.chromium.org/1808223003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/login_login_oobe_shared.js:34:
disableTextSelectAndDrag(function(e) {
I think this should be done in login_shared.js, as we want disable text
selection on the lock screen as well.

[jdufault, 2016-03-26 00:14:58]

> I'm not sure about lazy loading of Polymer as well. I don't think that lazy
> loading
> of a single file will save us much time. On the other hand it can possible
lead
> to UI glitches.

Actually, this is one of the most significant gains. There is a 200ms fixed
loading section that remains constant across devices. With synchronous polymer,
we load on a link in 0.73s, and with async polymer we load in 0.5s.

Accounting for the 200ms fixed delay, it's actually 0.53s vs 0.3s. On a slow
device, these values will get inflated significantly (the 200ms should be
constant), so keeping this number low is the biggest priority.

[jdufault, 2016-03-28 17:30:38]

Done, please take another look. Thanks!

https://codereview.chromium.org/1808223003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/login_login_oobe_shared.js (right):

https://codereview.chromium.org/1808223003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/login_login_oobe_shared.js:34:
disableTextSelectAndDrag(function(e) {
On 2016/03/25 22:17:36, dzhioev wrote:
> I think this should be done in login_shared.js, as we want disable text
> selection on the lock screen as well.

Done.

[jdufault, 2016-04-06 00:09:21]

ping dzhioev@

[dzhioev (left Google), 2016-04-12 18:13:37]

LGTM

[jdufault, 2016-04-12 18:30:02]

Description was changed from

==========
Refactor oobe/login screens so lock screen can be loaded faster.

Split lock screen from login assets, so lock screen only loads the minimal
number of files needed.

Split login_common.js into two files, login_shared.js and
login_login_oobe_shared.js.

Split login_resources.html into two files, login_shared.html and
login_login_oobe_shared.html.

Lazy load polymer for user_pod_template.



BUG=452599
==========

to

==========
Refactor oobe/login screens so lock screen can be loaded faster.

Split lock screen from login assets, so lock screen only loads the minimal
number of files needed.

Split login_common.js into two files, login_shared.js and
login_non_lock_shared.js.

Split login_resources.html into two files, login_shared.html and
login_non_lock_shared.html.

Lazy load polymer for user_pod_template.


BUG=452599
==========

[jdufault, 2016-04-12 18:30:02]

jdufault@chromium.org changed reviewers:
+ xiyuan@chromium.org

[jdufault, 2016-04-12 18:30:22]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2016-04-12 18:31:19]

+xiyuan@ PTAL at browser_resources.grd

+achuith@ for FYI

Thanks!

[xiyuan, 2016-04-12 18:33:45]

browser_resources.grd LGTM

[jdufault, 2016-04-12 19:23:52]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-04-12 19:24:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808223003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808223003/40001

[commit-bot: I haz the power, 2016-04-12 20:14:47]

Description was changed from

==========
Refactor oobe/login screens so lock screen can be loaded faster.

Split lock screen from login assets, so lock screen only loads the minimal
number of files needed.

Split login_common.js into two files, login_shared.js and
login_non_lock_shared.js.

Split login_resources.html into two files, login_shared.html and
login_non_lock_shared.html.

Lazy load polymer for user_pod_template.


BUG=452599
==========

to

==========
Refactor oobe/login screens so lock screen can be loaded faster.

Split lock screen from login assets, so lock screen only loads the minimal
number of files needed.

Split login_common.js into two files, login_shared.js and
login_non_lock_shared.js.

Split login_resources.html into two files, login_shared.html and
login_non_lock_shared.html.

Lazy load polymer for user_pod_template.


BUG=452599
==========

[commit-bot: I haz the power, 2016-04-12 20:14:48]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-04-12 20:16:24]

Description was changed from

==========
Refactor oobe/login screens so lock screen can be loaded faster.

Split lock screen from login assets, so lock screen only loads the minimal
number of files needed.

Split login_common.js into two files, login_shared.js and
login_non_lock_shared.js.

Split login_resources.html into two files, login_shared.html and
login_non_lock_shared.html.

Lazy load polymer for user_pod_template.


BUG=452599
==========

to

==========
Refactor oobe/login screens so lock screen can be loaded faster.

Split lock screen from login assets, so lock screen only loads the minimal
number of files needed.

Split login_common.js into two files, login_shared.js and
login_non_lock_shared.js.

Split login_resources.html into two files, login_shared.html and
login_non_lock_shared.html.

Lazy load polymer for user_pod_template.

BUG=452599

Committed: https://crrev.com/3ce610430e914400d917c949d2811293c28505b9
Cr-Commit-Position: refs/heads/master@{#386789}
==========

[commit-bot: I haz the power, 2016-04-12 20:16:25]

Patchset 2 (id:??) landed as
https://crrev.com/3ce610430e914400d917c949d2811293c28505b9
Cr-Commit-Position: refs/heads/master@{#386789}