[OnionSoup] Moving VR service from content to Blink

third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index b9fdefc5cf29e20ac2d1ee4508ce7959bb473841..6e2213dacb4b6f9b77c580d5035c817a6f3e6a22 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -182,6 +182,7 @@
 #include "platform/network/ResourceRequest.h"
 #include "platform/scroll/ScrollTypes.h"
 #include "platform/scroll/ScrollbarTheme.h"
+#include "platform/vr/vr_dispatcher.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SchemeRegistry.h"
 #include "platform/weborigin/SecurityPolicy.h"
@@ -1556,7 +1557,7 @@ void WebLocalFrameImpl::setCoreFrame(PassRefPtrWillBeRawPtr<LocalFrame> frame)
     if (RuntimeEnabledFeatures::webUSBEnabled())
         USBController::provideTo(*m_frame, m_client ? m_client->usbClient() : nullptr);
     if (RuntimeEnabledFeatures::webVREnabled())
-        VRController::provideTo(*m_frame, m_client ? m_client->webVRClient() : nullptr);
+        VRController::provideTo(*m_frame, VRDispatcher::create());

[Yuki, 2016/03/22 07:15:03]

I think you no longer need this line.  The clients of VR can directly call into
the VR APIs because both of clients and the API implementation live in Blink.

[RaviKasibhatla, 2016/03/23 15:20:51]

I am sorry but I didn't understood the concern here. We do need to set the frame
and WebVR client and hence we need to call the client creation.

Are you implying instead of calling from here, VRController directly calls for
client creation, since VRController holds the reference to the WebVRClient
(VRDispatcher)?

All builds where feature was disabled were failing because of linker error at
this statement. So, in new patch, I have added createWebVRClient API which
returns 0 when the feature is disabled - checking using ENABLE(WEBVR).
If there is a better way to handle the linker error, please suggest.

[Yuki, 2016/03/25 09:49:05]

Yes.  As you're moving the implementation from content/ to Blink's platform/,
there should be no need to communicate with content/, no need to communicate
through WebLocalFrame, I think.

I've not yet dug into deep, I guess that we could get rid of WebLocalFrame.
It seems compile errors happening.  Please fix them first, and run trybots so
that we can see linker errors.

     if (RuntimeEnabledFeatures::wakeLockEnabled())
         ScreenWakeLock::provideTo(*m_frame, m_client ? m_client->wakeLockClient() : nullptr);
     if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())