[OnionSoup] Moving VR service from content to Blink

third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 164 matching lines @@
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/GraphicsLayerClient.h"
 #include "platform/graphics/paint/ClipRecorder.h"
 #include "platform/graphics/paint/DrawingRecorder.h"
 #include "platform/graphics/paint/SkPictureBuilder.h"
 #include "platform/graphics/skia/SkiaUtils.h"
 #include "platform/heap/Handle.h"
 #include "platform/network/ResourceRequest.h"
 #include "platform/scroll/ScrollTypes.h"
 #include "platform/scroll/ScrollbarTheme.h"
+#include "platform/vr/vr_dispatcher.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SchemeRegistry.h"
 #include "platform/weborigin/SecurityPolicy.h"
 #include "public/platform/WebFloatPoint.h"
 #include "public/platform/WebFloatRect.h"
 #include "public/platform/WebLayer.h"
 #include "public/platform/WebPoint.h"
 #include "public/platform/WebRect.h"
 #include "public/platform/WebSecurityOrigin.h"
 #include "public/platform/WebSize.h"
@@ skipping 1354 matching lines @@
 
     if (RuntimeEnabledFeatures::screenOrientationEnabled())
         ScreenOrientationController::provideTo(*m_frame, m_client ? m_client->webScreenOrientationClient() : nullptr);
     if (RuntimeEnabledFeatures::presentationEnabled())
         PresentationController::provideTo(*m_frame, m_client ? m_client->presentationClient() : nullptr);
     if (RuntimeEnabledFeatures::permissionsEnabled())
         PermissionController::provideTo(*m_frame, m_client ? m_client->permissionClient() : nullptr);
     if (RuntimeEnabledFeatures::webUSBEnabled())
         USBController::provideTo(*m_frame, m_client ? m_client->usbClient() : nullptr);
     if (RuntimeEnabledFeatures::webVREnabled())
-        VRController::provideTo(*m_frame, m_client ? m_client->webVRClient() : nullptr);
+        VRController::provideTo(*m_frame, VRDispatcher::create());

[Yuki, 2016/03/22 07:15:03]

I think you no longer need this line.  The clients of VR can directly call into
the VR APIs because both of clients and the API implementation live in Blink.

[RaviKasibhatla, 2016/03/23 15:20:51]

I am sorry but I didn't understood the concern here. We do need to set the frame
and WebVR client and hence we need to call the client creation.

Are you implying instead of calling from here, VRController directly calls for
client creation, since VRController holds the reference to the WebVRClient
(VRDispatcher)?

All builds where feature was disabled were failing because of linker error at
this statement. So, in new patch, I have added createWebVRClient API which
returns 0 when the feature is disabled - checking using ENABLE(WEBVR).
If there is a better way to handle the linker error, please suggest.

[Yuki, 2016/03/25 09:49:05]

Yes.  As you're moving the implementation from content/ to Blink's platform/,
there should be no need to communicate with content/, no need to communicate
through WebLocalFrame, I think.

I've not yet dug into deep, I guess that we could get rid of WebLocalFrame.
It seems compile errors happening.  Please fix them first, and run trybots so
that we can see linker errors.

     if (RuntimeEnabledFeatures::wakeLockEnabled())
         ScreenWakeLock::provideTo(*m_frame, m_client ? m_client->wakeLockClient() : nullptr);
     if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())
         provideAudioOutputDeviceClientTo(*m_frame, AudioOutputDeviceClientImpl::create());
     if (RuntimeEnabledFeatures::installedAppEnabled())
         InstalledAppController::provideTo(*m_frame, m_client ? m_client->installedAppClient() : nullptr);
 }
 
 void WebLocalFrameImpl::initializeCoreFrame(FrameHost* host, FrameOwner* owner, const AtomicString& name, const AtomicString& uniqueName)
 {
@@ skipping 617 matching lines @@
         return WebSandboxFlags::None;
     return static_cast<WebSandboxFlags>(frame()->loader().effectiveSandboxFlags());
 }
 
 void WebLocalFrameImpl::forceSandboxFlags(WebSandboxFlags flags)
 {
     frame()->loader().forceSandboxFlags(static_cast<SandboxFlags>(flags));
 }
 
 } // namespace blink