third_party/WebKit/Source/modules/vr/VRController.h - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRController.h

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/vr/vr_type_converters.cc ('k') | third_party/WebKit/Source/modules/vr/VRController.cpp » ('j') | third_party/WebKit/Source/platform/vr/vr_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRController.h

diff --git a/third_party/WebKit/Source/modules/vr/VRController.h b/third_party/WebKit/Source/modules/vr/VRController.h

index fed11d5e663a17a4ee21dcf3b5cad64e7140cd1c..c404ffa8e133f1fb8028b98d6128af9d30d2f669 100644

--- a/third_party/WebKit/Source/modules/vr/VRController.h

+++ b/third_party/WebKit/Source/modules/vr/VRController.h

@@ -40,7 +40,7 @@ private:

// Inherited from LocalFrameLifecycleObserver.

void willDetachFrameHost() override;

- WebVRClient* m_client;

+ RefPtrWillBeMember<WebVRClient> m_client;

haraken 2016/03/19 00:45:18 This looks wrong. - You cannot use RefPtr in non-

RaviKasibhatla 2016/03/21 15:12:01 I have added Member<VRDispatcher> in VRController.

};

} // namespace blink