third_party/WebKit/Source/modules/vr/VRController.h - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/vr/VRController.h

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/renderer/vr/vr_type_converters.cc ('k') | third_party/WebKit/Source/modules/vr/VRController.cpp » ('j') | third_party/WebKit/Source/platform/vr/vr_dispatcher.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef VRController_h	5 #ifndef VRController_h

6 #define VRController_h	6 #define VRController_h

7	7

8 #include "core/frame/LocalFrameLifecycleObserver.h"	8 #include "core/frame/LocalFrameLifecycleObserver.h"

9 #include "modules/ModulesExport.h"	9 #include "modules/ModulesExport.h"

10 #include "platform/Supplementable.h"	10 #include "platform/Supplementable.h"

(...skipping 22 matching lines...) Expand all Loading...
33 static const char* supplementName();	33 static const char* supplementName();

34	34

35 DECLARE_VIRTUAL_TRACE();	35 DECLARE_VIRTUAL_TRACE();

36	36

37 private:	37 private:

38 VRController(LocalFrame&, WebVRClient*);	38 VRController(LocalFrame&, WebVRClient*);

39	39

40 // Inherited from LocalFrameLifecycleObserver.	40 // Inherited from LocalFrameLifecycleObserver.

41 void willDetachFrameHost() override;	41 void willDetachFrameHost() override;

42	42

43 WebVRClient* m_client;	43 RefPtrWillBeMember<WebVRClient> m_client;
	haraken 2016/03/19 00:45:18 This looks wrong. - You cannot use RefPtr in non- This looks wrong. - You cannot use RefPtr in non-oilpan because WebVRClient is not RefCounted. I guess this will cause compile error in non-oilpan... - You cannot use Member in oilpan because WebVRClient is not GarbageCollected. RaviKasibhatla 2016/03/21 15:12:01 I have added Member<VRDispatcher> in VRController. Show quoted text On 2016/03/19 00:45:18, haraken wrote: > > This looks wrong. > > - You cannot use RefPtr in non-oilpan because WebVRClient is not RefCounted. I > guess this will cause compile error in non-oilpan... > > - You cannot use Member in oilpan because WebVRClient is not GarbageCollected. I have added Member<VRDispatcher> in VRController. Also, made VRDispatcher a garbage collected class. PTAL current approach and let me know if I am doing anything wrong.
44 };	44 };

45	45

46 } // namespace blink	46 } // namespace blink

47	47

48 #endif // VRController_h	48 #endif // VRController_h

OLD	NEW