Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 180803005: HAllocate should never generate allocation code if the requested size does not fit into page. Regre… (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

HAllocate should never generate allocation code if the requested size does not fit into page. Regression test included. BUG=347543 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M src/a64/lithium-codegen-a64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-347543.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-02-27 17:24:09 UTC) #1
Hannes Payer (out of office)
LGTM
6 years, 9 months ago (2014-02-27 17:26:39 UTC) #2
Igor Sheludko
6 years, 9 months ago (2014-02-27 17:33:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19591 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698