src/arm/lithium-codegen-arm.cc - Issue 180803005: HAllocate should never generate allocation code if the requested size does not fit into page. Regre…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 180803005: HAllocate should never generate allocation code if the requested size does not fit into page. Regre… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 51126db7aae9550ba99f20a889b930b541ae8d47..8c9221cc4a60efaea356afea7df79cb34589b29c 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -5252,7 +5252,11 @@ void LCodeGen::DoAllocate(LAllocate* instr) {

if (instr->size()->IsConstantOperand()) {

int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));

- __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags);

+ if (size <= Page::kMaxRegularHeapObjectSize) {

+ __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags);

+ } else {

+ __ jmp(deferred->entry());

+ }

} else {

__ Allocate(size,

« no previous file with comments | « src/a64/lithium-codegen-a64.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »