Source/core/dom/Text.cpp - Issue 18080016: [CSS Regions] Elements in a region should be assignable to a named flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Text.cpp

Issue 18080016: [CSS Regions] Elements in a region should be assignable to a named flow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/NodeRenderingContext.cpp ('K') | « Source/core/dom/PseudoElement.h ('k') | Source/core/rendering/FlowThreadController.h » ('j') | Source/core/rendering/FlowThreadController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Text.cpp

diff --git a/Source/core/dom/Text.cpp b/Source/core/dom/Text.cpp

index 119d1dc6eb4288b9c2d73b189472cdfceba08c5e..23646d6296360e625d937ef407751b9cd17186e4 100644

--- a/Source/core/dom/Text.cpp

+++ b/Source/core/dom/Text.cpp

@@ -297,7 +297,12 @@ void Text::updateTextRenderer(unsigned offsetOfReplacedData, unsigned lengthOfRe

if (!attached())

return;

RenderText* textRenderer = toRenderText(renderer());

- if (!textRenderer || !textRendererIsNeeded(NodeRenderingContext(this, textRenderer->style()))) {

+ if (!textRenderer) {

+ reattach();

+ return;

+ }

+ NodeRenderingContext renderingContext(this, textRenderer->style());

+ if (!textRendererIsNeeded(renderingContext)) {

reattach();

return;

esprehn 2013/06/28 20:29:36 Why did you change this code? What you have looks

}