Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 18080016: [CSS Regions] Elements in a region should be assignable to a named flow (Closed)

Created:
7 years, 5 months ago by stavila
Modified:
7 years, 5 months ago
Reviewers:
esprehn, Mihai Maerean
CC:
blink-reviews, chromiumbugtracker_adobe.com, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), adamk+blink_chromium.org, jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DOM children of a region must not be rendered as children of the region, but can be collected in flow threads. Ported and improved from https://bugs.webkit.org/show_bug.cgi?id=74144 BUG=228566 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153439

Patch Set 1 #

Total comments: 21

Patch Set 2 : Small tweak, ready to commit #

Patch Set 3 : Implemented suggestions from esprehn #

Total comments: 5

Patch Set 4 : Final patch #

Patch Set 5 : Fixed failing test (fullscreen issue), added SVG test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -23 lines) Patch
A LayoutTests/fast/regions/flow-body-in-html.html View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/flow-body-in-html-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/region-content-flown-into-region.html View 1 2 3 4 1 chunk +117 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/region-content-flown-into-region-expected.html View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/universal-selector-children-to-the-same-region.html View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/universal-selector-children-to-the-same-region-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 3 chunks +30 lines, -0 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/dom/NodeRenderingContext.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/NodeRenderingContext.cpp View 1 2 3 3 chunks +29 lines, -21 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/FlowThreadController.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/FlowThreadController.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
stavila
Please review. If it looks good, please LGTM but DO NOT commit. I want to ...
7 years, 5 months ago (2013-06-28 17:37:39 UTC) #1
Mihai Maerean
On 2013/06/28 17:37:39, stavila wrote: > Please review. If it looks good, please LGTM but ...
7 years, 5 months ago (2013-06-28 18:38:40 UTC) #2
stavila
@Mihai I know, Mihnea & Catalin wanted me to finish this as you will not ...
7 years, 5 months ago (2013-06-28 19:43:39 UTC) #3
esprehn
https://codereview.chromium.org/18080016/diff/1/LayoutTests/fast/regions/flow-body-in-html.html File LayoutTests/fast/regions/flow-body-in-html.html (right): https://codereview.chromium.org/18080016/diff/1/LayoutTests/fast/regions/flow-body-in-html.html#newcode9 LayoutTests/fast/regions/flow-body-in-html.html:9: -webkit-flow-from: foo; Whitespace is still wrong in these tests. ...
7 years, 5 months ago (2013-06-28 20:29:36 UTC) #4
stavila
Thanks for the suggestions, I'll implement them monday.
7 years, 5 months ago (2013-06-28 20:37:46 UTC) #5
esprehn
On 2013/06/28 20:37:46, stavila wrote: > Thanks for the suggestions, I'll implement them monday. btw, ...
7 years, 5 months ago (2013-06-28 20:41:19 UTC) #6
stavila
On 2013/06/28 20:41:19, esprehn wrote: > On 2013/06/28 20:37:46, stavila wrote: > > Thanks for ...
7 years, 5 months ago (2013-06-28 21:20:02 UTC) #7
stavila
https://codereview.chromium.org/18080016/diff/1/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/18080016/diff/1/Source/core/dom/Element.cpp#newcode2662 Source/core/dom/Element.cpp:2662: return false; On 2013/06/28 20:29:36, esprehn wrote: > Interesting, ...
7 years, 5 months ago (2013-07-01 15:33:39 UTC) #8
esprehn
LGTM. Please fix comments before landing. https://codereview.chromium.org/18080016/diff/18001/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/18080016/diff/18001/Source/core/dom/Element.cpp#newcode2660 Source/core/dom/Element.cpp:2660: return !this->isRegisteredWithNamedFlow(document()->renderView()->flowThreadController()); I ...
7 years, 5 months ago (2013-07-01 18:27:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/18080016/32001
7 years, 5 months ago (2013-07-01 18:58:34 UTC) #10
Mihai Maerean
Please run the PerformanceTests/Parser/* tests (especially html5-full-render.html) and post the results to make sure this ...
7 years, 5 months ago (2013-07-01 19:03:35 UTC) #11
stavila
On 2013/07/01 19:03:35, Mihai Maerean wrote: > Please run the PerformanceTests/Parser/* tests (especially > html5-full-render.html) ...
7 years, 5 months ago (2013-07-01 19:21:07 UTC) #12
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=11211
7 years, 5 months ago (2013-07-01 20:20:44 UTC) #13
stavila
Performance results: html5-full-render -> 0.3% slower WITH patch css-parser-yui -> IDENTICAL html-parser -> 1.5% slower ...
7 years, 5 months ago (2013-07-01 21:19:52 UTC) #14
stavila
Performance looks good but there's a fullscreen test failing, I'll check tomorrow if it's related ...
7 years, 5 months ago (2013-07-01 21:26:58 UTC) #15
stavila
Adding the SVG test uncovered an unrelated issue. As such, https://code.google.com/p/chromium/issues/detail?id=256611 must land before committing ...
7 years, 5 months ago (2013-07-02 12:24:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/18080016/50001
7 years, 5 months ago (2013-07-02 15:22:10 UTC) #17
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=11316
7 years, 5 months ago (2013-07-02 17:43:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/18080016/50001
7 years, 5 months ago (2013-07-02 17:44:17 UTC) #19
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 20:02:14 UTC) #20
Message was sent while issue was closed.
Change committed as 153439

Powered by Google App Engine
This is Rietveld 408576698