[CSS Regions] Elements in a region should be assignable to a named flow

Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 2313 matching lines @@
 bool Element::isInCanvasSubtree() const
 {
     return hasRareData() && elementRareData()->isInCanvasSubtree();
 }
 
 bool Element::isUnresolvedCustomElement()
 {
     return isCustomElement() && document()->registry()->isUnresolved(this);
 }
 
+void Element::setIsDOMChildOfRegion(bool value)
+{
+    if (value == isDOMChildOfRegion())
+        return; // Will always be called during attaching, don't create rare data structure if not necessary.

[esprehn, 2013/06/28 20:29:36]

Remove the comment. This kind of oldValue == newValue is standard practice for
all rareData stuff, there's no reason to mention attaching.

+
+    ensureElementRareData()->setIsDOMChildOfRegion(value);
+}
+
+bool Element::isDOMChildOfRegion() const
+{
+    return hasRareData() ? elementRareData()->isDOMChildOfRegion() : false;
+}
+
 void Element::setRegionOversetState(RegionOversetState state)
 {
     ensureElementRareData()->setRegionOversetState(state);
 }
 
 RegionOversetState Element::regionOversetState() const
 {
     return hasRareData() ? elementRareData()->regionOversetState() : RegionUndefined;
 }
 
@@ skipping 278 matching lines @@
 }
 
 RenderRegion* Element::renderRegion() const
 {
     if (renderer() && renderer()->isRenderRegion())
         return toRenderRegion(renderer());
 
     return 0;
 }
 
+bool Element::shouldMoveToFlowThread(RenderStyle* styleToUse) const
+{
+    Document* doc = document();

[esprehn, 2013/06/28 20:29:36]

Remove this, just call document() below. You do it anyway for renderView().

+
+    if (!RuntimeEnabledFeatures::cssRegionsEnabled())

[esprehn, 2013/06/28 20:29:36]

This check should probably be in NodeRenderingContext not inside here.

+        return false;
+
+    ASSERT(styleToUse);
+    if (!styleToUse)
+        return false;

[esprehn, 2013/06/28 20:29:36]

Remove this, if you're asserting you shouldn't be guarding.

+
+#if ENABLE(FULLSCREEN_API)
+    if (doc->webkitIsFullScreen() && doc->webkitCurrentFullScreenElement() == this)

[esprehn, 2013/06/28 20:29:36]

FullScreenController::isActiveFullScreenElement(this) I think is what you want.
You don't need the webkitIsFullScreen() check.

+        return false;
+#endif
+
+    if (isInShadowTree())
+        return false;

[esprehn, 2013/06/28 20:29:36]

Interesting, so nothing inside a shadow is ever inside regions?

[stavila, 2013/07/01 15:33:39]

For the moment, no. It is still under discussion at the spec-level whether it
should be allowed or not.

+
+    if (styleToUse->flowThread().isEmpty())
+        return false;
+
+    return !document()->renderView()->flowThreadController()->isContentNodeRegisteredWithAnyNamedFlow(this);
+}
+
 const AtomicString& Element::webkitRegionOverset() const
 {
     document()->updateLayoutIgnorePendingStylesheets();
 
     DEFINE_STATIC_LOCAL(AtomicString, undefinedState, ("undefined", AtomicString::ConstructFromLiteral));
     if (!RuntimeEnabledFeatures::cssRegionsEnabled() || !renderRegion())
         return undefinedState;
 
     switch (renderRegion()->regionOversetState()) {
     case RegionFit: {
@@ skipping 924 matching lines @@
     return 0;
 }
 
 Attribute* UniqueElementData::attributeItem(unsigned index)
 {
     ASSERT_WITH_SECURITY_IMPLICATION(index < length());
     return &m_attributeVector.at(index);
 }
 
 } // namespace WebCore