Remove swapped out state from RenderFrameImpl.

Remove swapped out state from RenderFrameImpl.

BUG=357747
Committed: https://crrev.com/13c44c5c329fedc0a2c765edaf652747e5059be5
Cr-Commit-Position: refs/heads/master@{#381846}

[nasko, 2016-03-17 17:45:05]

nasko@chromium.org changed reviewers:
+ alexmos@chromium.org

[nasko, 2016-03-17 17:45:06]

Hey Alex,
Can you review this CL for me? It removes the swapped out state from the
RenderFrameImpl class, so no more such state on the renderer side either.
Thanks in advance!
Nasko

[alexmos, 2016-03-17 21:41:27]

LGTM!  Just one small nit/question below.

https://codereview.chromium.org/1807893002/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1807893002/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:4365: if (url::IsStandard(scheme.c_str(),
This reminded me to go clean this up, since url::Origin now handles such things
gracefully.  I'm going to put up a short CL for this and rebase on this once you
land it.

https://codereview.chromium.org/1807893002/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/1807893002/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.h:1011: // RenderFrameProxy exists only when
is_swapped_out_ is true.
This now talks about a non-existing flag, so maybe update this comment?  Were
you planning to deal with the proxy in a separate CL?

[nasko, 2016-03-17 23:19:11]

https://codereview.chromium.org/1807893002/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1807893002/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:4365: if (url::IsStandard(scheme.c_str(),
On 2016/03/17 21:41:27, alexmos wrote:
> This reminded me to go clean this up, since url::Origin now handles such
things
> gracefully.  I'm going to put up a short CL for this and rebase on this once
you
> land it.

Acknowledged.

https://codereview.chromium.org/1807893002/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/1807893002/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.h:1011: // RenderFrameProxy exists only when
is_swapped_out_ is true.
On 2016/03/17 21:41:27, alexmos wrote:
> This now talks about a non-existing flag, so maybe update this comment?  Were
> you planning to deal with the proxy in a separate CL?

Thanks for catching that. Yes, I will look at whether we still need to keep this
proxy separately. I want to keep the CLs clean and easy to reason about.

[nasko, 2016-03-17 23:24:02]

The CQ bit was checked by nasko@chromium.org

[nasko, 2016-03-17 23:24:02]

The patchset sent to the CQ was uploaded after l-g-t-m from alexmos@chromium.org
Link to the patchset: https://codereview.chromium.org/1807893002/#ps40001
(title: "Remove stale comment.")

[commit-bot: I haz the power, 2016-03-17 23:24:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807893002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807893002/40001

[commit-bot: I haz the power, 2016-03-18 00:21:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-18 00:24:42]

Description was changed from

==========
Remove swapped out state from RenderFrameImpl.

BUG=357747
==========

to

==========
Remove swapped out state from RenderFrameImpl.

BUG=357747

Committed: https://crrev.com/13c44c5c329fedc0a2c765edaf652747e5059be5
Cr-Commit-Position: refs/heads/master@{#381846}
==========

[commit-bot: I haz the power, 2016-03-18 00:24:43]

Patchset 3 (id:??) landed as
https://crrev.com/13c44c5c329fedc0a2c765edaf652747e5059be5
Cr-Commit-Position: refs/heads/master@{#381846}