Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 1807893002: Remove swapped out state from RenderFrameImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove stale comment. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 // routing ID. Also stores the opener's RenderView routing ID into 218 // routing ID. Also stores the opener's RenderView routing ID into
219 // |opener_view_routing_id|. 219 // |opener_view_routing_id|.
220 // 220 //
221 // TODO(alexmos): remove RenderViewImpl's dependency on 221 // TODO(alexmos): remove RenderViewImpl's dependency on
222 // opener_view_routing_id. 222 // opener_view_routing_id.
223 static blink::WebFrame* ResolveOpener(int opener_frame_routing_id, 223 static blink::WebFrame* ResolveOpener(int opener_frame_routing_id,
224 int* opener_view_routing_id); 224 int* opener_view_routing_id);
225 225
226 ~RenderFrameImpl() override; 226 ~RenderFrameImpl() override;
227 227
228 bool is_swapped_out() const {
229 return is_swapped_out_;
230 }
231
232 // TODO(nasko): This can be removed once we don't have a swapped out state on 228 // TODO(nasko): This can be removed once we don't have a swapped out state on
233 // RenderFrames. See https://crbug.com/357747. 229 // RenderFrames. See https://crbug.com/357747.
234 void set_render_frame_proxy(RenderFrameProxy* proxy) { 230 void set_render_frame_proxy(RenderFrameProxy* proxy) {
235 render_frame_proxy_ = proxy; 231 render_frame_proxy_ = proxy;
236 } 232 }
237 233
238 // Called by RenderWidget when meaningful layout has happened. 234 // Called by RenderWidget when meaningful layout has happened.
239 // See RenderFrameObserver::DidMeaningfulLayout declaration for details. 235 // See RenderFrameObserver::DidMeaningfulLayout declaration for details.
240 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type); 236 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type);
241 237
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 #if defined(ENABLE_WEBVR) 615 #if defined(ENABLE_WEBVR)
620 blink::WebVRClient* webVRClient() override; 616 blink::WebVRClient* webVRClient() override;
621 #endif 617 #endif
622 618
623 // WebFrameSerializerClient implementation: 619 // WebFrameSerializerClient implementation:
624 void didSerializeDataForFrame( 620 void didSerializeDataForFrame(
625 const blink::WebCString& data, 621 const blink::WebCString& data,
626 blink::WebFrameSerializerClient::FrameSerializationStatus status) 622 blink::WebFrameSerializerClient::FrameSerializationStatus status)
627 override; 623 override;
628 624
629 // Make this frame show an empty, unscriptable page.
630 // TODO(nasko): Remove this method once swapped out state is no longer used.
631 void NavigateToSwappedOutURL();
632
633 // Binds this render frame's service registry. 625 // Binds this render frame's service registry.
634 void BindServiceRegistry( 626 void BindServiceRegistry(
635 mojo::shell::mojom::InterfaceProviderRequest services, 627 mojo::shell::mojom::InterfaceProviderRequest services,
636 mojo::shell::mojom::InterfaceProviderPtr exposed_services); 628 mojo::shell::mojom::InterfaceProviderPtr exposed_services);
637 629
638 ManifestManager* manifest_manager(); 630 ManifestManager* manifest_manager();
639 631
640 // TODO(creis): Remove when the only caller, the HistoryController, is no 632 // TODO(creis): Remove when the only caller, the HistoryController, is no
641 // more. 633 // more.
642 void SetPendingNavigationParams( 634 void SetPendingNavigationParams(
(...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after
1008 // if there is a RenderFrameProxy for the same frame. It is inserted into the 1000 // if there is a RenderFrameProxy for the same frame. It is inserted into the
1009 // frame tree at the time the pending navigation commits. 1001 // frame tree at the time the pending navigation commits.
1010 // Frames added by the parent document are created from the renderer process 1002 // Frames added by the parent document are created from the renderer process
1011 // and are immediately inserted in the frame tree. 1003 // and are immediately inserted in the frame tree.
1012 // TODO(dcheng): Remove this once we have FrameTreeHandle and can use the 1004 // TODO(dcheng): Remove this once we have FrameTreeHandle and can use the
1013 // Blink Web* layer to check for provisional frames. 1005 // Blink Web* layer to check for provisional frames.
1014 bool in_frame_tree_; 1006 bool in_frame_tree_;
1015 1007
1016 base::WeakPtr<RenderViewImpl> render_view_; 1008 base::WeakPtr<RenderViewImpl> render_view_;
1017 int routing_id_; 1009 int routing_id_;
1018 bool is_swapped_out_;
1019 1010
1020 // RenderFrameProxy exists only when is_swapped_out_ is true.
1021 // TODO(nasko): This can be removed once we don't have a swapped out state on 1011 // TODO(nasko): This can be removed once we don't have a swapped out state on
1022 // RenderFrame. See https://crbug.com/357747. 1012 // RenderFrame. See https://crbug.com/357747.
1023 RenderFrameProxy* render_frame_proxy_; 1013 RenderFrameProxy* render_frame_proxy_;
1024 bool is_detaching_; 1014 bool is_detaching_;
1025 1015
1026 // If this frame was created to replace a proxy, this will store the routing 1016 // If this frame was created to replace a proxy, this will store the routing
1027 // id of the proxy to replace at commit-time, at which time it will be 1017 // id of the proxy to replace at commit-time, at which time it will be
1028 // cleared. 1018 // cleared.
1029 // TODO(creis): Remove this after switching to PlzNavigate. 1019 // TODO(creis): Remove this after switching to PlzNavigate.
1030 int proxy_routing_id_; 1020 int proxy_routing_id_;
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
1211 #endif 1201 #endif
1212 1202
1213 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1203 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1214 1204
1215 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1205 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1216 }; 1206 };
1217 1207
1218 } // namespace content 1208 } // namespace content
1219 1209
1220 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1210 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/accessibility/renderer_accessibility.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698