third_party/WebKit/Source/wtf/text/WTFString.h - Issue 1807853003: Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 1807853003: Deprecate some macros in wtf/Assertions.h in favor of base/logging.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Many updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/wtf/Assertions.h ('K') | « third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp ('k') | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('j') | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/text/WTFString.h

diff --git a/third_party/WebKit/Source/wtf/text/WTFString.h b/third_party/WebKit/Source/wtf/text/WTFString.h

index 0b1b4ea8fd153ea6f4baae0726940c95b34a97f1..258eccb6c16dca826eba224af213c7bb1d2d860d 100644

--- a/third_party/WebKit/Source/wtf/text/WTFString.h

+++ b/third_party/WebKit/Source/wtf/text/WTFString.h

@@ -28,7 +28,6 @@

#include "wtf/Allocator.h"

#include "wtf/HashTableDeletedValueType.h"

#include "wtf/WTFExport.h"

-#include "wtf/testing/WTFUnitTestHelpersExport.h"

#include "wtf/text/ASCIIFastPath.h"

#include "wtf/text/StringImpl.h"

#include "wtf/text/StringView.h"

@@ -678,8 +677,8 @@ WTF_EXPORT const String& emptyString();

WTF_EXPORT const String& emptyString16Bit();

WTF_EXPORT extern const String& xmlnsWithColon;

-// Pretty printer for gtest. Declared here to avoid ODR violations.

-WTF_UNITTEST_HELPERS_EXPORT std::ostream& operator<<(std::ostream&, const String&);

+// Pretty printer for gtest and base/loggin.*.

+WTF_EXPORT std::ostream& operator<<(std::ostream&, const String&);

} // namespace WTF