third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp - Issue 1807853003: Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

Issue 1807853003: Deprecate some macros in wtf/Assertions.h in favor of base/logging.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Many updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/wtf/Assertions.h ('K') | « third_party/WebKit/Source/wtf/text/TextCodecICU.cpp ('k') | third_party/WebKit/Source/wtf/text/WTFString.h » ('j') | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

diff --git a/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp b/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

index 1c5ad1aee59781cc8cb63e2f6f53028701f112db..aa0a47fe795fef494080b81b6aca70afbd108a21 100644

--- a/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

+++ b/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

@@ -150,7 +150,7 @@ static void checkExistingName(const char* alias, const char* atomicName)

&& strcmp(oldAtomicName, "ISO-8859-8-I") == 0

&& strcasecmp(atomicName, "iso-8859-8") == 0)

return;

- WTF_LOG_ERROR("alias %s maps to %s already, but someone is trying to make it map to %s", alias, oldAtomicName, atomicName);

+ LOG(ERROR) << "alias " << alias << " maps to " << oldAtomicName << " already, but someone is trying to make it map to " << atomicName;

}

#endif