Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issue 1807833002: Welcome isSameNode back as a per-spec method (Closed)

Created:
4 years, 9 months ago by philipj_slow
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Welcome isSameNode back as a per-spec method The spec change has been reverted: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27424#c21 https://dom.spec.whatwg.org/#interface-node There's no need to measure usage any longer, as not further change is likely to ever happen. BUG=460722 R=yosin@chromium.org Committed: https://crrev.com/5d19b64a0bb32e40c501eb9a620757c9ac7c94af Cr-Commit-Position: refs/heads/master@{#381420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
philipj_slow
4 years, 9 months ago (2016-03-16 06:22:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807833002/1
4 years, 9 months ago (2016-03-16 06:23:04 UTC) #3
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-16 06:32:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807833002/1
4 years, 9 months ago (2016-03-16 06:32:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 07:43:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807833002/1
4 years, 9 months ago (2016-03-16 08:30:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 08:35:25 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 08:36:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d19b64a0bb32e40c501eb9a620757c9ac7c94af
Cr-Commit-Position: refs/heads/master@{#381420}

Powered by Google App Engine
This is Rietveld 408576698