Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: third_party/WebKit/Source/core/dom/Node.idl

Issue 1807833002: Welcome isSameNode back as a per-spec method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Node.idl
diff --git a/third_party/WebKit/Source/core/dom/Node.idl b/third_party/WebKit/Source/core/dom/Node.idl
index 12251c5999d425d53e415f200d9e54e4cacd69c5..b16f9d2ca7cf8a842d3e47b8a1b8071154ea84c6 100644
--- a/third_party/WebKit/Source/core/dom/Node.idl
+++ b/third_party/WebKit/Source/core/dom/Node.idl
@@ -59,7 +59,8 @@
[CustomElementCallbacks] void normalize();
[NewObject, CustomElementCallbacks] Node cloneNode(optional boolean deep = false);
- boolean isEqualNode(Node? node);
+ boolean isEqualNode(Node? otherNode);
+ boolean isSameNode(Node? otherNode); // historical alias of ===
const unsigned short DOCUMENT_POSITION_DISCONNECTED = 0x01;
const unsigned short DOCUMENT_POSITION_PRECEDING = 0x02;
@@ -78,8 +79,4 @@
[CustomElementCallbacks, PerWorldBindings, RaisesException] Node appendChild(Node node);
[CustomElementCallbacks, PerWorldBindings, RaisesException] Node replaceChild(Node node, Node child);
[CustomElementCallbacks, RaisesException] Node removeChild(Node child);
-
- // FIXME: isSameNode has been removed from the spec:
- // https://www.w3.org/Bugs/Public/show_bug.cgi?id=27424
- [MeasureAs=NodeIsSameNode, ImplementedAs=isSameNodeDeprecated] boolean isSameNode(Node? other);
};
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698