Issue 180773004: Merge 168113 "Fix crash when resizing a view destroys the render..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180773004: Merge 168113 "Fix crash when resizing a view destroys the render..." (Closed)

Created:
6 years, 9 months ago by pdr.

Modified:
6 years, 9 months ago

Reviewers:
pdr.

CC:
blink-reviews, pdr, Stephen Chennney, krit, f(malita), rwlbuis

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1750/

Visibility:
Public.

More Reviews

Description

Merge 168113 "Fix crash when resizing a view destroys the render..." > Fix crash when resizing a view destroys the render tree > > This is a simple fix for not holding a renderer across FrameView > resizes. Calling view->resize() can destroy renderers so this patch > updates SVGImage::setContainerSize to query the renderer after the > resize is complete. A similar issue does not exist for the dom tree > which is not destroyed. > > BUG=344492 > > Review URL: https://codereview.chromium.org/178043006 TBR=pdr@chromium.org BUG=344492 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168152

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -0 lines)			Patch
A +	LayoutTests/svg/custom/draw-image-crash.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/svg/custom/draw-image-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/svg/custom/resources/draw-image-crash.svg	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/svg/graphics/SVGImage.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r168152.

Expand Messages | Collapse Messages