Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178043006: Fix crash when resizing a view destroys the render tree (Closed)

Created:
6 years, 9 months ago by pdr.
Modified:
6 years, 9 months ago
Reviewers:
aarya, inferno
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Fix crash when resizing a view destroys the render tree This is a simple fix for not holding a renderer across FrameView resizes. Calling view->resize() can destroy renderers so this patch updates SVGImage::setContainerSize to query the renderer after the resize is complete. A similar issue does not exist for the dom tree which is not destroyed. BUG=344492 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168113

Patch Set 1 #

Patch Set 2 : Can haz test? #

Patch Set 3 : Cleanup test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
A LayoutTests/svg/custom/draw-image-crash.html View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A + LayoutTests/svg/custom/draw-image-crash-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/custom/resources/draw-image-crash.svg View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
pdr.
6 years, 9 months ago (2014-02-27 22:26:02 UTC) #1
aarya
lgtm
6 years, 9 months ago (2014-02-27 22:29:51 UTC) #2
inferno
lgtm
6 years, 9 months ago (2014-02-27 22:30:06 UTC) #3
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-02-27 22:31:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/178043006/20001
6 years, 9 months ago (2014-02-27 22:31:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/178043006/20001
6 years, 9 months ago (2014-02-28 01:05:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 03:26:54 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=29554
6 years, 9 months ago (2014-02-28 03:26:54 UTC) #8
inferno
The CQ bit was checked by inferno@chromium.org
6 years, 9 months ago (2014-02-28 03:57:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/178043006/20001
6 years, 9 months ago (2014-02-28 03:57:32 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 06:40:08 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=29596
6 years, 9 months ago (2014-02-28 06:40:08 UTC) #12
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-02-28 07:18:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/178043006/40001
6 years, 9 months ago (2014-02-28 07:18:33 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 09:33:54 UTC) #15
Message was sent while issue was closed. 
Change committed as 168113

Powered by Google App Engine
This is Rietveld 408576698