[css-flexbox] Correctly handle percentage sizing in the main axis

[css-flexbox] Correctly handle percentage sizing in the main axis

Flex items should have a definite size subject to certain conditions:
https://drafts.csswg.org/css-flexbox/#definite-sizes

This patch implements part 2 of that section.

This also fixes a bug in definite-cross-sizes; I put the flex-one
class on the wrong div.

flex-flow-padding has percentage children of flexboxes and thus
needed updating.

BUG=346275
NOPRESUBMIT=true

Committed: https://crrev.com/ab4d700467b65a395a64c02d1a7d2777950ec0cd
Cr-Commit-Position: refs/heads/master@{#381385}

[cbiesinger, 2016-03-15 20:30:44]

cbiesinger@chromium.org changed reviewers:
+ leviw@chromium.org

[cbiesinger, 2016-03-15 20:30:55]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 20:31:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807653002/1

[commit-bot: I haz the power, 2016-03-15 22:14:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 22:14:55]

Dry run: This issue passed the CQ dry run.

[leviw_travelin_and_unemployed, 2016-03-16 00:57:49]

Woot! LGTM.

https://codereview.chromium.org/1807653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp (right):

https://codereview.chromium.org/1807653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:1108: if (mainSize
== LayoutUnit(-1)) {
Nit: unnecessary brackets.

https://codereview.chromium.org/1807653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:1111: if
(hasOrthogonalFlow(child)) {
Ditto.

[cbiesinger, 2016-03-16 01:28:08]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-03-16 01:28:09]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1807653002/#ps20001
(title: "remove unnecessary brackets")

[commit-bot: I haz the power, 2016-03-16 01:28:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807653002/20001

[commit-bot: I haz the power, 2016-03-16 01:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:37:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[cbiesinger, 2016-03-16 01:39:52]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:40:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807653002/20001

[commit-bot: I haz the power, 2016-03-16 01:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:48:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[cbiesinger, 2016-03-16 02:01:56]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-03-16 02:02:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807653002/20001

[commit-bot: I haz the power, 2016-03-16 02:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 02:11:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[cbiesinger, 2016-03-16 02:18:09]

Description was changed from

==========
[css-flexbox] Correctly handle percentage sizing in the main axis

Flex items should have a definite size subject to certain conditions:
https://drafts.csswg.org/css-flexbox/#definite-sizes

This patch implements part 2 of that section.

This also fixes a bug in definite-cross-sizes; I put the flex-one
class on the wrong div.

flex-flow-padding has percentage children of flexboxes and thus
needed updating.

BUG=346275
==========

to

==========
[css-flexbox] Correctly handle percentage sizing in the main axis

Flex items should have a definite size subject to certain conditions:
https://drafts.csswg.org/css-flexbox/#definite-sizes

This patch implements part 2 of that section.

This also fixes a bug in definite-cross-sizes; I put the flex-one
class on the wrong div.

flex-flow-padding has percentage children of flexboxes and thus
needed updating.

BUG=346275
NOPRESUBMIT=true
==========

[cbiesinger, 2016-03-16 02:18:15]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-03-16 02:18:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807653002/20001

[commit-bot: I haz the power, 2016-03-16 02:37:22]

Description was changed from

==========
[css-flexbox] Correctly handle percentage sizing in the main axis

Flex items should have a definite size subject to certain conditions:
https://drafts.csswg.org/css-flexbox/#definite-sizes

This patch implements part 2 of that section.

This also fixes a bug in definite-cross-sizes; I put the flex-one
class on the wrong div.

flex-flow-padding has percentage children of flexboxes and thus
needed updating.

BUG=346275
NOPRESUBMIT=true
==========

to

==========
[css-flexbox] Correctly handle percentage sizing in the main axis

Flex items should have a definite size subject to certain conditions:
https://drafts.csswg.org/css-flexbox/#definite-sizes

This patch implements part 2 of that section.

This also fixes a bug in definite-cross-sizes; I put the flex-one
class on the wrong div.

flex-flow-padding has percentage children of flexboxes and thus
needed updating.

BUG=346275
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-03-16 02:37:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-16 02:38:51]

Description was changed from

==========
[css-flexbox] Correctly handle percentage sizing in the main axis

Flex items should have a definite size subject to certain conditions:
https://drafts.csswg.org/css-flexbox/#definite-sizes

This patch implements part 2 of that section.

This also fixes a bug in definite-cross-sizes; I put the flex-one
class on the wrong div.

flex-flow-padding has percentage children of flexboxes and thus
needed updating.

BUG=346275
NOPRESUBMIT=true
==========

to

==========
[css-flexbox] Correctly handle percentage sizing in the main axis

Flex items should have a definite size subject to certain conditions:
https://drafts.csswg.org/css-flexbox/#definite-sizes

This patch implements part 2 of that section.

This also fixes a bug in definite-cross-sizes; I put the flex-one
class on the wrong div.

flex-flow-padding has percentage children of flexboxes and thus
needed updating.

BUG=346275
NOPRESUBMIT=true

Committed: https://crrev.com/ab4d700467b65a395a64c02d1a7d2777950ec0cd
Cr-Commit-Position: refs/heads/master@{#381385}
==========

[commit-bot: I haz the power, 2016-03-16 02:38:53]

Patchset 2 (id:??) landed as
https://crrev.com/ab4d700467b65a395a64c02d1a7d2777950ec0cd
Cr-Commit-Position: refs/heads/master@{#381385}