Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html

Issue 1807653002: [css-flexbox] Correctly handle percentage sizing in the main axis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary brackets Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/css3/flexbox/definite-main-size.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html
diff --git a/third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html b/third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html
index f6f2a165706b5ed8a99234e472303be3cf325722..d78de16abd3972e0dda02cd73d333635917ccb03 100644
--- a/third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html
+++ b/third_party/WebKit/LayoutTests/css3/flexbox/definite-cross-sizes.html
@@ -81,11 +81,11 @@ is stretch (the default)</p>
</div>
</div>
-<p>Tests that we get an definite size in a nested flexbox where only the outer one has an explicit height and has an opposite direction. TODO: This is currently considered indefinite pending crbug.com/346275</p>
+<p>Tests that we get an definite size in a nested flexbox where only the outer one has an explicit height and has an opposite direction.</p>
<div class="flexbox" style="height: 50px;" data-expected-height="50">
- <div class="flexbox column flex-one" data-expected-height="50">
- <div data-expected-height="50">
- <div style="height: 50%" data-expected-height="50"> <!-- TODO: should be 25 pending the above bug -->
+ <div class="flexbox column" data-expected-height="50">
+ <div class="flex-one" data-expected-height="50">
+ <div style="height: 50%" data-expected-height="25">
<div class="rect" data-expected-height="50"></div>
</div>
</div>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/css3/flexbox/definite-main-size.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698