Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: components/test_runner/test_runner.cc

Issue 1807643002: Make test_runner::AppBannerClient an internal detail of components/test_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review... Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index a92105f1745669c096077d450b0c1ce80b2b27ba..466cab44cb30c191fcbd4a79ea46ed4f997689a3 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -14,6 +14,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
+#include "components/test_runner/app_banner_client.h"
#include "components/test_runner/mock_credential_manager_client.h"
#include "components/test_runner/mock_web_speech_recognizer.h"
#include "components/test_runner/test_interfaces.h"
@@ -1551,7 +1552,7 @@ void TestRunnerBindings::ResolveBeforeInstallPromptPromise(
if (!runner_)
return;
- return runner_->ResolveBeforeInstallPromptPromise(request_id, platform);
+ runner_->ResolveBeforeInstallPromptPromise(request_id, platform);
}
std::string TestRunnerBindings::PlatformName() {
@@ -2934,7 +2935,7 @@ void TestRunner::DispatchBeforeInstallPromptEvent(
void TestRunner::ResolveBeforeInstallPromptPromise(
int request_id,
const std::string& platform) {
- delegate_->ResolveBeforeInstallPromptPromise(request_id, platform);
+ test_interfaces_->GetAppBannerClient()->ResolvePromise(request_id, platform);
Łukasz Anforowicz 2016/03/15 21:57:28 This is what the delegate (i.e. BlinkTestRunner) w
}
void TestRunner::SetPOSIXLocale(const std::string& locale) {

Powered by Google App Engine
This is Rietveld 408576698