Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1807643002: Make test_runner::AppBannerClient an internal detail of components/test_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review... Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index 08e1e4eebdeb502a738d00479b963420d8233108..5016bd4eb882b18108bc113e34d156f8de6f9949 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -29,13 +29,11 @@
#include "base/values.h"
#include "build/build_config.h"
#include "components/plugins/renderer/plugin_placeholder.h"
-#include "components/test_runner/app_banner_client.h"
#include "components/test_runner/gamepad_controller.h"
#include "components/test_runner/layout_dump.h"
#include "components/test_runner/layout_dump_flags.h"
#include "components/test_runner/mock_screen_orientation_client.h"
#include "components/test_runner/test_interfaces.h"
-#include "components/test_runner/tracked_dictionary.h"
Łukasz Anforowicz 2016/03/15 21:57:28 Not really part of this CL... :-/ But it is also
#include "components/test_runner/web_task.h"
#include "components/test_runner/web_test_interfaces.h"
#include "components/test_runner/web_test_proxy.h"
@@ -761,14 +759,6 @@ void BlinkTestRunner::DispatchBeforeInstallPromptEvent(
callback.Run(reply == blink::WebAppBannerPromptReply::Cancel);
}
-void BlinkTestRunner::ResolveBeforeInstallPromptPromise(
- int request_id, const std::string& platform) {
- test_runner::WebTestInterfaces* interfaces =
- LayoutTestRenderProcessObserver::GetInstance()->test_interfaces();
- if (interfaces->GetAppBannerClient())
- interfaces->GetAppBannerClient()->ResolvePromise(request_id, platform);
-}
-
blink::WebPlugin* BlinkTestRunner::CreatePluginPlaceholder(
blink::WebLocalFrame* frame, const blink::WebPluginParams& params) {
if (params.mimeType != "application/x-plugin-placeholder-test")

Powered by Google App Engine
This is Rietveld 408576698