Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180743028: Oilpan: move Worker objects to the oilpan heap. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
Reviewers:
oilpan-reviews, tkent
CC:
blink-reviews, arv+blink, falken, Inactive, horo+watch_chromium.org, kinuko+watch, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: move Worker objects to the oilpan heap. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169116

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Patch Set 3 : Have SharedWorkerRepositoryClient use transition type(s) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -15 lines) Patch
M Source/core/workers/AbstractWorker.h View 3 chunks +5 lines, -2 lines 0 comments Download
M Source/core/workers/AbstractWorker.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/workers/SharedWorker.h View 3 chunks +4 lines, -1 line 0 comments Download
M Source/core/workers/SharedWorker.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/workers/SharedWorker.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/SharedWorkerRepositoryClient.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/workers/Worker.h View 3 chunks +4 lines, -1 line 0 comments Download
M Source/core/workers/Worker.cpp View 4 chunks +9 lines, -3 lines 0 comments Download
M Source/core/workers/Worker.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
sof
Please take a look.
6 years, 9 months ago (2014-03-06 21:23:03 UTC) #1
sof
Please take a look.
6 years, 9 months ago (2014-03-06 21:23:04 UTC) #2
sof
https://codereview.chromium.org/180743028/diff/1/Source/core/workers/Worker.cpp File Source/core/workers/Worker.cpp (right): https://codereview.chromium.org/180743028/diff/1/Source/core/workers/Worker.cpp#newcode106 Source/core/workers/Worker.cpp:106: if (m_contextProxy) cf. https://codereview.chromium.org/177073004/diff/1/Source/core/workers/Worker.cpp#newcode106
6 years, 9 months ago (2014-03-06 21:55:27 UTC) #3
sof
ping? :)
6 years, 9 months ago (2014-03-12 15:19:32 UTC) #4
tkent
lgtm. Don't you update SharedWorkerConnector::m_worker? https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp&q=RefPtr%3CSharedWorker%3E%20file:WebKit/Source&sq=package:chromium&type=cs&l=78
6 years, 9 months ago (2014-03-13 05:02:19 UTC) #5
sof
On 2014/03/13 05:02:19, tkent wrote: > lgtm. > > Don't you update SharedWorkerConnector::m_worker? > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp&q=RefPtr%253CSharedWorker%253E%2520file:WebKit/Source&sq=package:chromium&type=cs&l=78 ...
6 years, 9 months ago (2014-03-13 07:04:24 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-13 07:53:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/180743028/40001
6 years, 9 months ago (2014-03-13 07:53:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 08:28:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_blink_rel
6 years, 9 months ago (2014-03-13 08:28:47 UTC) #10
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-13 08:31:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/180743028/40001
6 years, 9 months ago (2014-03-13 08:31:15 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 09:03:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_blink
6 years, 9 months ago (2014-03-13 09:03:09 UTC) #14
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-13 09:15:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/180743028/40001
6 years, 9 months ago (2014-03-13 09:15:38 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 09:41:47 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_blink_rel
6 years, 9 months ago (2014-03-13 09:41:48 UTC) #18
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-13 10:27:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/180743028/40001
6 years, 9 months ago (2014-03-13 10:27:32 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 11:05:59 UTC) #21
Message was sent while issue was closed. 
Change committed as 169116

Powered by Google App Engine
This is Rietveld 408576698