Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2700)

Unified Diff: Source/web/SharedWorkerRepositoryClientImpl.cpp

Issue 180743028: Oilpan: move Worker objects to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have SharedWorkerRepositoryClient use transition type(s) Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/SharedWorkerRepositoryClientImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/SharedWorkerRepositoryClientImpl.cpp
diff --git a/Source/web/SharedWorkerRepositoryClientImpl.cpp b/Source/web/SharedWorkerRepositoryClientImpl.cpp
index fcff0b2021909cd39c1fce240ca6ae5b62d7d13b..11793f728218421937a194d35775f664600f4891 100644
--- a/Source/web/SharedWorkerRepositoryClientImpl.cpp
+++ b/Source/web/SharedWorkerRepositoryClientImpl.cpp
@@ -60,7 +60,7 @@ namespace blink {
// Callback class that keeps the SharedWorker and WebSharedWorker objects alive while connecting.
class SharedWorkerConnector : private WebSharedWorkerConnector::ConnectListener {
public:
- SharedWorkerConnector(PassRefPtr<SharedWorker> worker, const KURL& url, const String& name, PassOwnPtr<WebMessagePortChannel> channel, PassOwnPtr<WebSharedWorkerConnector> webWorkerConnector)
+ SharedWorkerConnector(PassRefPtrWillBeRawPtr<SharedWorker> worker, const KURL& url, const String& name, PassOwnPtr<WebMessagePortChannel> channel, PassOwnPtr<WebSharedWorkerConnector> webWorkerConnector)
: m_worker(worker)
, m_url(url)
, m_name(name)
@@ -75,7 +75,7 @@ private:
virtual void connected() OVERRIDE;
virtual void scriptLoadFailed() OVERRIDE;
- RefPtr<SharedWorker> m_worker;
+ RefPtrWillBePersistent<SharedWorker> m_worker;
KURL m_url;
String m_name;
OwnPtr<WebSharedWorkerConnector> m_webWorkerConnector;
@@ -111,7 +111,7 @@ static WebSharedWorkerRepositoryClient::DocumentID getId(void* document)
return reinterpret_cast<WebSharedWorkerRepositoryClient::DocumentID>(document);
}
-void SharedWorkerRepositoryClientImpl::connect(PassRefPtr<SharedWorker> worker, PassOwnPtr<WebMessagePortChannel> port, const KURL& url, const String& name, ExceptionState& exceptionState)
+void SharedWorkerRepositoryClientImpl::connect(PassRefPtrWillBeRawPtr<SharedWorker> worker, PassOwnPtr<WebMessagePortChannel> port, const KURL& url, const String& name, ExceptionState& exceptionState)
{
ASSERT(m_client);
« no previous file with comments | « Source/web/SharedWorkerRepositoryClientImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698