Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 180743026: Relanding 255326 "HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist" (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton, rmistry1
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Relanding 255326 - Implement MRU for AlternateProtocolMap. Persist only the most recently used 200 entries. In memory keep all the entries. The following is the revert of revert description: Revert 255326 "Revert of HttpServerProperties - Implement MRU fo..." > Revert of HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist (https://codereview.chromium.org/182383016/) > > Reason for revert: > Broke compile on a bunch of bots: > Chromium Linux Builder (valgrind) > Chromium OS Builder (valgrind) > Chromium Windows Builder (DrMemory) > Linux Builder (TSan v2) > > Log: > http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20Builder%20%28valgrind%29/builds/73182/steps/compile/logs/stdio > > > Original issue's description: > > HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist > > only the most recently used 200 entries. In memory keep all the entries. > > > > BUG=258189 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255323 > > TBR=rch@chromium.org,rtenneti@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=258189 > > Review URL: https://codereview.chromium.org/188663002 TBR=rmistry@chromium.org, rch@chromium.org BUG=258189 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255569

Patch Set 1 #

Patch Set 2 : Use Erase to fix compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -45 lines) Patch
M chrome/browser/net/http_server_properties_manager.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 9 chunks +21 lines, -10 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties.h View 3 chunks +5 lines, -3 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 8 chunks +39 lines, -21 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 2 chunks +59 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
Uploaded the fix for compilation error in patch set 1
6 years, 9 months ago (2014-03-06 19:52:26 UTC) #1
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 19:52:32 UTC) #2
Ryan Hamilton
LGTM
6 years, 9 months ago (2014-03-06 19:54:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/180743026/20001
6 years, 9 months ago (2014-03-06 19:58:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/180743026/20001
6 years, 9 months ago (2014-03-06 21:05:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/180743026/20001
6 years, 9 months ago (2014-03-06 21:59:30 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 09:33:57 UTC) #7
Message was sent while issue was closed.
Change committed as 255569

Powered by Google App Engine
This is Rietveld 408576698