Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 188663002: Revert of HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist (Closed)

Created:
6 years, 9 months ago by rmistry1
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke, jar (doing other things), wtc
Visibility:
Public.

Description

Revert of HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist (https://codereview.chromium.org/182383016/) Reason for revert: Broke compile on a bunch of bots: Chromium Linux Builder (valgrind) Chromium OS Builder (valgrind) Chromium Windows Builder (DrMemory) Linux Builder (TSan v2) Log: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20Builder%20%28valgrind%29/builds/73182/steps/compile/logs/stdio Original issue's description: > HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist > only the most recently used 200 entries. In memory keep all the entries. > > BUG=258189 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255323 TBR=rch@chromium.org,rtenneti@chromium.org NOTREECHECKS=true NOTRY=true BUG=258189 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -130 lines) Patch
M chrome/browser/net/http_server_properties_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 9 chunks +10 lines, -21 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties.h View 3 chunks +3 lines, -5 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 8 chunks +21 lines, -37 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 2 chunks +2 lines, -59 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmistry1
Created Revert of HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist
6 years, 9 months ago (2014-03-06 13:39:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmistry@chromium.org/188663002/1
6 years, 9 months ago (2014-03-06 13:39:59 UTC) #2
commit-bot: I haz the power
Change committed as 255326
6 years, 9 months ago (2014-03-06 13:40:43 UTC) #3
rmistry1
6 years, 9 months ago (2014-03-06 13:40:45 UTC) #4
Message was sent while issue was closed.
On 2014/03/06 13:39:52, rmistry1 wrote:
> Created Revert of HttpServerProperties - Implement MRU for
AlternateProtocolMap.
> Persist

Here's a better log link:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20B...

Powered by Google App Engine
This is Rietveld 408576698