guard against invalid request id / method

pkg/analysis_server/lib/src/protocol.dart

Index: pkg/analysis_server/lib/src/protocol.dart
diff --git a/pkg/analysis_server/lib/src/protocol.dart b/pkg/analysis_server/lib/src/protocol.dart
index 9423825157d03a017efef429bc17f666308a9e62..287b201892b642e79193ca351626a5d0591f8b5f 100644
--- a/pkg/analysis_server/lib/src/protocol.dart
+++ b/pkg/analysis_server/lib/src/protocol.dart
@@ -73,8 +73,11 @@ class Request {
       if (result is! Map) {
         return null;
       }
-      String id = result[Request.ID];
-      String method = result[Request.METHOD];
+      var id = result[Request.ID];
+      var method = result[Request.METHOD];
+      if (id is! String || method is! String) {
+        return null;
+      }
       var params = result[Request.PARAMS];
       Request request = new Request(id, method);
       if (params is Map) {

[Brian Wilkerson, 2014/03/05 16:15:16]

So it looks like we're returning null if the format is not correct. If that's
the case, shouldn't we be returning null if params is not a Map?

[danrubel, 2014/03/05 18:39:07]

Good point. Done.