Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180743018: Move SigninTracker away from listening for SigninManager notifications (Closed)

Created:
6 years, 9 months ago by blundell
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Move SigninTracker away from listening for SigninManager notifications As part of eliminating Signin-related notifications, move SigninTracker to observing the SigninManager. BUG=349375 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255292

Patch Set 1 #

Patch Set 2 : Move include of SigninManagerFactory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -34 lines) Patch
M chrome/browser/signin/fake_signin_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
chrome/browser/signin/fake_signin_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_tracker.h View 4 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/signin/signin_tracker.cc View 1 3 chunks +6 lines, -17 lines 0 comments Download
chrome/browser/signin/signin_tracker_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
blundell
6 years, 9 months ago (2014-03-04 21:47:23 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 9 months ago (2014-03-05 16:01:18 UTC) #2
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-05 16:38:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/180743018/1
6 years, 9 months ago (2014-03-05 16:40:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 17:05:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53638
6 years, 9 months ago (2014-03-05 17:05:53 UTC) #6
blundell
TBR=thakis for //chrome/browser/ui/bookmarks
6 years, 9 months ago (2014-03-05 17:08:05 UTC) #7
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-05 17:08:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/180743018/1
6 years, 9 months ago (2014-03-05 17:09:00 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 17:26:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-05 17:26:19 UTC) #11
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-05 17:54:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/180743018/1
6 years, 9 months ago (2014-03-05 17:55:02 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 18:14:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-05 18:14:26 UTC) #15
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-05 21:54:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/180743018/20001
6 years, 9 months ago (2014-03-05 21:55:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/180743018/20001
6 years, 9 months ago (2014-03-06 00:04:04 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:25:07 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 01:25:08 UTC) #20
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-06 06:09:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/180743018/20001
6 years, 9 months ago (2014-03-06 06:12:32 UTC) #22
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:29:06 UTC) #23
Message was sent while issue was closed. 
Change committed as 255292

Powered by Google App Engine
This is Rietveld 408576698