Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7454)

Unified Diff: chrome/browser/signin/signin_tracker.h

Issue 180743018: Move SigninTracker away from listening for SigninManager notifications (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move include of SigninManagerFactory Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/fake_signin_manager.cc ('k') | chrome/browser/signin/signin_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_tracker.h
diff --git a/chrome/browser/signin/signin_tracker.h b/chrome/browser/signin/signin_tracker.h
index 351c086c2bdb6141faeb3ae381766a05ed4e26a7..69dbcc347464613145af3a74f3776af990caf5fc 100644
--- a/chrome/browser/signin/signin_tracker.h
+++ b/chrome/browser/signin/signin_tracker.h
@@ -6,9 +6,7 @@
#define CHROME_BROWSER_SIGNIN_SIGNIN_TRACKER_H_
#include "base/memory/scoped_ptr.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
-#include "content/public/browser/notification_types.h"
+#include "chrome/browser/signin/signin_manager_base.h"
#include "google_apis/gaia/google_service_auth_error.h"
#include "google_apis/gaia/merge_session_helper.h"
#include "google_apis/gaia/oauth2_token_service.h"
@@ -48,7 +46,7 @@ class Profile;
// sync framework. Listens for notifications for tokens to know when to startup
// sync, and provides an Observer interface to notify the UI layer of changes
// in sync state so they can be reflected in the UI.
-class SigninTracker : public content::NotificationObserver,
+class SigninTracker : public SigninManagerBase::Observer,
public OAuth2TokenService::Observer,
public MergeSessionHelper::Observer {
public:
@@ -71,10 +69,8 @@ class SigninTracker : public content::NotificationObserver,
SigninTracker(Profile* profile, Observer* observer);
virtual ~SigninTracker();
- // content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
+ // SigninManagerBase::Observer implementation.
+ virtual void GoogleSigninFailed(const GoogleServiceAuthError& error) OVERRIDE;
// OAuth2TokenService::Observer implementation.
virtual void OnRefreshTokenAvailable(const std::string& account_id) OVERRIDE;
@@ -95,9 +91,6 @@ class SigninTracker : public content::NotificationObserver,
// Weak pointer to the observer we call when the signin state changes.
Observer* observer_;
- // Used to listen to notifications from the SigninManager.
- content::NotificationRegistrar registrar_;
-
DISALLOW_COPY_AND_ASSIGN(SigninTracker);
};
« no previous file with comments | « chrome/browser/signin/fake_signin_manager.cc ('k') | chrome/browser/signin/signin_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698