Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(57)

Issue 180743014: Allow the bootstrap binary of GN (the one in TEMPDIR) to build and run on FreeBSD. (Closed)

Created:
6 years, 4 months ago by r.c.ladan
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Allow the bootstrap binary of GN (the one in TEMPDIR) to build and run on FreeBSD. Tested on FreeBSD 8.4-i386 and FreeBSD 10.0-amd64 This issue depends on issues 185713005, 178193018, and 183803011 BUG=

Patch Set 1 #

Patch Set 2 : Submit a clean patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M tools/gn/args.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 5 chunks +35 lines, -12 lines 0 comments Download
M tools/gn/escape.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/settings.h View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/gn/settings.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
r.c.ladan
6 years, 4 months ago (2014-03-03 14:01:18 UTC) #1
r.c.ladan
On 2014/03/03 14:01:18, r.c.ladan wrote: I know GN is currently on hold, but nevertheless clean ...
6 years, 4 months ago (2014-03-10 23:01:15 UTC) #2
brettw
I'd rather not add support for not-officially-supported platforms right now, especially if I'm not working ...
6 years, 4 months ago (2014-03-10 23:20:14 UTC) #3
r.c.ladan
On 2014/03/10 23:20:14, brettw wrote: > I'd rather not add support for not-officially-supported platforms right ...
6 years, 1 month ago (2014-06-10 19:54:32 UTC) #4
riggs
5 years, 10 months ago (2014-09-10 13:26:11 UTC) #5
On 2014/03/10 23:20:14, brettw wrote:
> I'd rather not add support for not-officially-supported platforms right now,
> especially if I'm not working on it.

Is there a technical reason for not including them? The patches are tiny and
straightforward and inclusion does not imply a commitment to support FreeBSD as
an official platform. It just acknowledges community contribution and the
interest to make it more portable in the long run. This is not a bad sign, is
it?

Best regards

Powered by Google App Engine
This is Rietveld 408576698