Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1807363002: Remove lifecycle rewinding in FrameView::scheduleRelayout (Closed)

Created:
4 years, 9 months ago by chrishtr
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove lifecycle rewinding in FrameView::scheduleRelayout It was added in https://codereview.chromium.org/232013002 to find extra lifecycle violations. However, right now it is used in various cases to schedule relayout during layout because of change of containing block chain. This triggers the assert incorrectly (or layout should fix this, but it is considered ok for now). BUG=594489 Committed: https://crrev.com/b1c6edeac6287b6ffe50cac44956b72f29bb76f5 Cr-Commit-Position: refs/heads/master@{#381997}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
chrishtr
4 years, 9 months ago (2016-03-17 23:00:32 UTC) #3
leviw_travelin_and_unemployed
LGTM! Thanks for fixing this, Dr. DJ 'Lifecycle' Chris.
4 years, 9 months ago (2016-03-18 00:32:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807363002/1
4 years, 9 months ago (2016-03-18 00:35:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/132597)
4 years, 9 months ago (2016-03-18 01:13:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807363002/20001
4 years, 9 months ago (2016-03-18 16:16:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 17:18:14 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 17:20:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1c6edeac6287b6ffe50cac44956b72f29bb76f5
Cr-Commit-Position: refs/heads/master@{#381997}

Powered by Google App Engine
This is Rietveld 408576698