Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

Issue 1807363002: Remove lifecycle rewinding in FrameView::scheduleRelayout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
index 48feb2a4d7b82529899f9adbc3a3825238bbb670..d0637d01cd2e79e7dc3ae407256fc298659d031a 100644
--- a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
+++ b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp
@@ -157,13 +157,16 @@ TEST_F(FrameThrottlingTest, ThrottledLifecycleUpdate)
// Mutating the throttled frame followed by a beginFrame will not result in
// a complete lifecycle update.
+ // TODO(skyostil): these expectations are either wrong, or the test is
+ // not exercising the code correctly. PaintClean means the entire lifecycle
+ // ran.
frameElement->setAttribute(widthAttr, "50");
compositeFrame();
- EXPECT_EQ(DocumentLifecycle::StyleClean, frameDocument->lifecycle().state());
+ EXPECT_EQ(DocumentLifecycle::PaintClean, frameDocument->lifecycle().state());
// A hit test will not force a complete lifecycle update.
webView().hitTestResultAt(WebPoint(0, 0));
- EXPECT_EQ(DocumentLifecycle::StyleClean, frameDocument->lifecycle().state());
+ EXPECT_EQ(DocumentLifecycle::PaintClean, frameDocument->lifecycle().state());
}
TEST_F(FrameThrottlingTest, UnthrottlingFrameSchedulesAnimation)
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698