Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1807333004: [Extensions] Allow overriding a nested options page for opening a new instance (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Extensions] Allow overriding a nested options page for opening a new instance If there is an existing chrome://extensions page open, it should be able to be overridden to show an extension's options page if that options page opens in a view in the chrome://extensions page. BUG=595253 Review URL: https://codereview.chromium.org/1805013005 Cr-Commit-Position: refs/heads/master@{#381555} (cherry picked from commit 6ef722eae199b14ba8b6670568647b0905099442) Committed: https://chromium.googlesource.com/chromium/src/+/3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -27 lines) Patch
M chrome/browser/extensions/extension_tab_util.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util_browsertest.cc View 2 chunks +59 lines, -26 lines 0 comments Download
A + chrome/test/data/extensions/options_page_in_view/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/options_page_in_view/options.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/options_page_in_view/other.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 9 months ago (2016-03-18 23:12:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3250f0efded0140f6c26ee6c7e63ddac0e2cc4a9.

Powered by Google App Engine
This is Rietveld 408576698