Push ScriptWrappable inheritance down from SVGAnimatedPropertyBase

Push ScriptWrappable inheritance down from SVGAnimatedPropertyBase

Rather than letting the base inherit and then override for actually
wrappable subclasses, put the inheritance in the subclasses.
This avoids having "dead" ScriptWrappables on subclasses that don't need
this functionality.
Since this removes the last user of the DEFINE_WRAPPERTYPEINFO_NOT_REACHED
macro, remove that too.

BUG=596011
Committed: https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c
Cr-Commit-Position: refs/heads/master@{#382265}

[fs, 2016-03-18 14:08:36]

fs@opera.com changed reviewers:
+ haraken@chromium.org, kouhei@chromium.org

[haraken, 2016-03-19 00:09:12]

LGTM

https://codereview.chromium.org/1807333003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h (left):

https://codereview.chromium.org/1807333003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h:50:
DEFINE_WRAPPERTYPEINFO_NOT_REACHED();

SVGAnimatedPropertyBase was the only customer of the macro. We can remove the
macro from ScriptWrappable.h.

[fs, 2016-03-21 09:16:50]

Description was changed from

==========
Push ScriptWrappable inheritance down from SVGAnimatedPropertyBase

Rather than letting the base inherit and then override for actually
wrappable subclasses, put the inheritance in the subclasses.
This avoids having "dead" ScriptWrappables on subclasses that don't need
this functionality.

BUG=596011
==========

to

==========
Push ScriptWrappable inheritance down from SVGAnimatedPropertyBase

Rather than letting the base inherit and then override for actually
wrappable subclasses, put the inheritance in the subclasses.
This avoids having "dead" ScriptWrappables on subclasses that don't need
this functionality.
Since this removes the last user of the DEFINE_WRAPPERTYPEINFO_NOT_REACHED
macro, remove that too.

BUG=596011
==========

[fs, 2016-03-21 09:17:48]

https://codereview.chromium.org/1807333003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h (left):

https://codereview.chromium.org/1807333003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h:50:
DEFINE_WRAPPERTYPEINFO_NOT_REACHED();
On 2016/03/19 at 00:09:12, haraken wrote:
> SVGAnimatedPropertyBase was the only customer of the macro. We can remove the
macro from ScriptWrappable.h.

Removed.

[fs, 2016-03-21 10:02:46]

The CQ bit was checked by fs@opera.com

[fs, 2016-03-21 10:02:46]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1807333003/#ps20001
(title: "Remove DEFINE_WRAPPERTYPEINFO_NOT_REACHED.")

[commit-bot: I haz the power, 2016-03-21 10:03:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807333003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807333003/20001

[commit-bot: I haz the power, 2016-03-21 10:51:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-21 10:52:50]

Description was changed from

==========
Push ScriptWrappable inheritance down from SVGAnimatedPropertyBase

Rather than letting the base inherit and then override for actually
wrappable subclasses, put the inheritance in the subclasses.
This avoids having "dead" ScriptWrappables on subclasses that don't need
this functionality.
Since this removes the last user of the DEFINE_WRAPPERTYPEINFO_NOT_REACHED
macro, remove that too.

BUG=596011
==========

to

==========
Push ScriptWrappable inheritance down from SVGAnimatedPropertyBase

Rather than letting the base inherit and then override for actually
wrappable subclasses, put the inheritance in the subclasses.
This avoids having "dead" ScriptWrappables on subclasses that don't need
this functionality.
Since this removes the last user of the DEFINE_WRAPPERTYPEINFO_NOT_REACHED
macro, remove that too.

BUG=596011

Committed: https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c
Cr-Commit-Position: refs/heads/master@{#382265}
==========

[commit-bot: I haz the power, 2016-03-21 10:52:52]

Patchset 2 (id:??) landed as
https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c
Cr-Commit-Position: refs/heads/master@{#382265}

[kouhei (in TOK), 2016-03-22 01:38:08]

lgtm