Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 1807333003: Push ScriptWrappable inheritance down from SVGAnimatedPropertyBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove DEFINE_WRAPPERTYPEINFO_NOT_REACHED. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimatedAngle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
index 6fc72df6aa853d0055ef1ea189c0343943d0a9f0..44ea0f6a5308d3e80305968cd98110a8a2fac8b4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
@@ -232,26 +232,6 @@ public: \
private: \
static const WrapperTypeInfo& s_wrapperTypeInfo
-// Defines 'wrapperTypeInfo' virtual method, which should never be called.
-//
-// This macro is used when there exists a class hierarchy with a root class
-// and most of the subclasses are script-wrappable but not all of them.
-// In that case, the root class can inherit from ScriptWrappable and use
-// this macro, and let subclasses have a choice whether or not use
-// DEFINE_WRAPPERTYPEINFO macro. The script-wrappable subclasses which have
-// corresponding IDL file must call DEFINE_WRAPPERTYPEINFO, and the others
-// must not.
-#define DEFINE_WRAPPERTYPEINFO_NOT_REACHED() \
-public: \
- const WrapperTypeInfo* wrapperTypeInfo() const override \
- { \
- ASSERT_NOT_REACHED(); \
- return 0; \
- } \
-private: \
- typedef void end_of_define_wrappertypeinfo_not_reached_t
-
-
// Declares 'wrapperTypeInfo' method without definition.
//
// This macro is used for template classes. e.g. DOMTypedArray<>.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimatedAngle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698