Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180733003: DevTools: fix console to tail messages on devtools with zoomfactor != 1 (Closed)

Created:
6 years, 9 months ago by lushnikov
Modified:
6 years, 9 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: fix console to tail messages on devtools with zoomfactor != 1 This patch fixes method Element.isScrolledToBottom. The reason for this fix is that both clientHeight and scrollHeight are rounded to integer values. BUG=349399 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168643

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/devtools/front_end/DOMExtension.js View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
lushnikov
please take a look
6 years, 9 months ago (2014-03-05 13:19:40 UTC) #1
lushnikov
6 years, 9 months ago (2014-03-05 13:20:48 UTC) #2
apavlov
lgtm
6 years, 9 months ago (2014-03-05 13:22:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/180733003/1
6 years, 9 months ago (2014-03-05 13:23:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/180733003/1
6 years, 9 months ago (2014-03-05 20:58:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 00:33:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-06 00:33:02 UTC) #7
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-06 11:48:46 UTC) #8
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-06 11:48:55 UTC) #9
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-06 11:54:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/180733003/20001
6 years, 9 months ago (2014-03-06 11:54:49 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 11:56:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-06 11:56:02 UTC) #13
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-06 14:48:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/180733003/20001
6 years, 9 months ago (2014-03-06 14:49:25 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 15:54:56 UTC) #16
Message was sent while issue was closed. 
Change committed as 168643

Powered by Google App Engine
This is Rietveld 408576698