src/compiler/ppc/instruction-selector-ppc.cc - Issue 1807273002: [wasm] Int64Lowering of Int64Mul on ia32 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ppc/instruction-selector-ppc.cc

Issue 1807273002: [wasm] Int64Lowering of Int64Mul on ia32 and arm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-phi

Patch Set: Forgot to add the visit functions on mips, ppc, and x87. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ppc/instruction-selector-ppc.cc

diff --git a/src/compiler/ppc/instruction-selector-ppc.cc b/src/compiler/ppc/instruction-selector-ppc.cc

index c680648242eacf6c0bb6786edc0e6d7e9ad63e52..60b6242ce2d76375f85381b690ebac35701d1d4b 100644

--- a/src/compiler/ppc/instruction-selector-ppc.cc

+++ b/src/compiler/ppc/instruction-selector-ppc.cc

@@ -810,6 +810,8 @@ void InstructionSelector::VisitInt32PairSub(Node* node) {

VisitPairBinop(this, kPPC_SubPair, node);

}

+void InstructionSelector::VisitInt32PairMul(Node* node) { UNIMPLEMENTED(); }

void VisitPairShift(InstructionSelector* selector, ArchOpcode opcode,

Node* node) {

PPCOperandGenerator g(selector);