Issue 180723022: Revert 168384 "Use OwnPtrs for heap contains cache and persisten..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180723022: Revert 168384 "Use OwnPtrs for heap contains cache and persisten..." (Closed)

Created:
6 years, 9 months ago by eae

Modified:
6 years, 9 months ago

Reviewers:
Mads Ager (chromium)

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 168384 "Use OwnPtrs for heap contains cache and persisten..." Revert 168384 as it caused a serious crash (top #1 crasher on mac). BUG=349842 > Use OwnPtrs for heap contains cache and persistent anchor. We were leaking the HeapContainsCache. > > R=haraken@chromium.org, vegorov@chromium.org > BUG=348629 > NOTRY=true > > Review URL: https://codereview.chromium.org/183683017 TBR=ager@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168676

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
M	trunk/Source/heap/Handle.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/Source/heap/ThreadState.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/Source/heap/ThreadState.cpp	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (chromium)

6 years, 9 months ago (2014-03-07 10:29:57 UTC) #3

Message was sent while issue was closed.

This cannot be the cause of that crash. I have a change out to fix the crash and
I will reland this.